On 19.10.2012 13:15, Nozomi Kodama wrote:
I'd prefer "const" because it is used a little bit more often than CONST, but it is only a matter of taste. git grep "[ (,]const " | wc -l ~61k git grep "[ (,]CONST " | wc -l ~1.2k
I'd write it "if (i >= square || ((... for consistency.
Expected -> expected? (2 times)
The spacing looks a bit ugly.
Cheers Rico
On 22 October 2012 09:06, Rico Schüller kgbricola@web.de wrote:
IIRC "CONST" is some kind of hack for compilers that don't (fully) support const. I think it's unlikely you'll be able to compile a working Wine with such a compiler even if you can find one, these days probably even things like MSVC, Sun Studio and Clang support const. And even if you could, something along the lines of AC_C_CONST would probably be a better solution anyway. It seems tempting to cleanup the couple of places in Wine that use "CONST", and add a __ONLY_IN_WINELIB to the #define in include/windef.h.
On 10/22/2012 11:21 AM, Henri Verbeet wrote:
I'm removing CONST in the lines I touch so +1 on a concerted effort to eradicate it. Though at 1.2k lines Alexandre might consider it too spammy.
bye michael
Michael Stefaniuc mstefani@redhat.com writes:
I'm removing CONST in the lines I touch so +1 on a concerted effort to eradicate it. Though at 1.2k lines Alexandre might consider it too spammy.
Yes, that's too much for a large scale cleanup.