OpenGL child windows (bug 2398, fixed!)

[Roderick Colenbrander]

Hi,

Thanks to Chris his recent child window work, there is now support for OpenGL child windows in Wine. For the exact details read bug 2398 or Chris his patches. In short the patches use XComposite were possible and else X pixmaps. Not all drivers support both properly yet but for compiz/aiglx purposes most drivers are adding the needed support.

I would say test the stuff and report problems.

Roderick

[Florian Köberle]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi

I tried the Window with Button Demo from:
http://bugs.winehq.org/attachment.cgi?id=5777

The main window still overdraw the button.

Used wine version:
57a67ebcceb08639736f218f0f545aa41737ad96

graphic card:
GeForce 7800 GTX

driver:
NVIDIA UNIX x86 Kernel Module  100.14.11

Thanks for the try to fix it anyway.

Roderick Colenbrander wrote:
> Hi,
>
> Thanks to Chris his recent child window work, there is now support for OpenGL child windows in Wine. For the exact details read bug 2398 or Chris his patches. In short the patches use XComposite were possible and else X pixmaps. Not all drivers support both properly yet but for compiz/aiglx purposes most drivers are adding the needed support.
>
> I would say test the stuff and report problems.
>
> Roderick
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHA6Az59ca4mzhfxMRAtBxAJ4jQkJHrmdYPZcWSMbF7shCmUOqRQCgxNKl
PKWECKHlSl7uvDIbYIBWkIE=
=fRaM
-----END PGP SIGNATURE-----

[Roderick Colenbrander]

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi
>
> I tried the Window with Button Demo from:
> http://bugs.winehq.org/attachment.cgi?id=5777
>
> The main window still overdraw the button.
>
> Used wine version:
> 57a67ebcceb08639736f218f0f545aa41737ad96
>
> graphic card:
> GeForce 7800 GTX
>
> driver:
> NVIDIA UNIX x86 Kernel Module  100.14.11
>
> Thanks for the try to fix it anyway.
>
> Roderick Colenbrander wrote:
> > Hi,
> >
> > Thanks to Chris his recent child window work, there is now support for
>
> OpenGL child windows in Wine. For the exact details read bug 2398 or Chris
> his patches. In short the patches use XComposite were possible and else X
> pixmaps. Not all drivers support both properly yet but for compiz/aiglx
> purposes most drivers are adding the needed support.
> > I would say test the stuff and report problems.
> >
> > Roderick

Actually the example you gave is one of the corner cases which I don't think are expected to work (windows has lots of issues in that area too). You should try apps like Google Earth, Google Sketchup, professional CAD apps and so on. Those should work fine.

Roderick

[Chris Robinson]

On Wednesday 03 October 2007 06:59:15 am Florian Köberle wrote:
> Hi
>
> I tried the Window with Button Demo from:
> http://bugs.winehq.org/attachment.cgi?id=5777
>
> The main window still overdraw the button.
>
> Used wine version:
> 57a67ebcceb08639736f218f0f545aa41737ad96
>
> graphic card:
> GeForce 7800 GTX
>
> driver:
> NVIDIA UNIX x86 Kernel Module  100.14.11
>
> Thanks for the try to fix it anyway.

This seems to be due to a couple factors. First, since the GL window is the 
top-level window, it draws to it directly so it doesn't get clipped. Second, 
CreateWindow for the GL window is missing the WS_CLIPCHILDREN flag. If I 
force offscreen rendering and add the flag, the demo works.

What can probably be done is to check if the window has the flags set to clip 
from children, and don't allow onscreen rendering with that. Then the only 
question is why Windows is assuming WS_CLIPCHILDREN for the window (maybe 
CreateWindow implies it while CreateWindowEx doesn't?).

[L. Rahyen]

On Wednesday October 3 2007 11:44, Roderick Colenbrander wrote:
> Hi,
>
> Thanks to Chris his recent child window work, there is now support for
> OpenGL child windows in Wine. For the exact details read bug 2398 or Chris
> his patches. In short the patches use XComposite were possible and else X
> pixmaps. Not all drivers support both properly yet but for compiz/aiglx
> purposes most drivers are adding the needed support.
>
> I would say test the stuff and report problems.
>
> Roderick

I have tested Lightwave 6 (didn't yet tested new version but I guess it will 
work too), GoogleEarth (for Windows) and Maxwell Studio 1.5.1 (for Windows) 
and everything works fine! I'm using Debian Etch and KDE 3.5.5 and my X 
server has XComposite extension enabled but I don't actually use it in KDE so 
I'm not sure does this have any useful effect or not.
    It's so great that this bug is finally fixed! I really tired to port big 
hacky patches to new versions of WINE... Now everything works out-of-the box!
    Great work!

[denis bonnenfant]

I tested git version with solidworks, and now it's worse than  with
previous chris patch :

- quite slow, just like with composite patch
- highlighted lines offset, just like with composite patch
- GLXbaddrawable crash when opening multiple windows, regression from
the composite patch, that allows multiple windows

It looks like all the previous issues are cumulated !

maybe I missed something ?

Denis

[Roderick Colenbrander]

> I tested git version with solidworks, and now it's worse than  with
> previous chris patch :
> - quite slow, just like with composite patch
> - highlighted lines offset, just like with composite patch
> - GLXbaddrawable crash when opening multiple windows, regression from
>
> the composite patch, that allows multiple windows
>
> It looks like all the previous issues are cumulated !
>
> maybe I missed something ?
>
> Denis

What display drivers are you using? In general Nvidia's drivers are the only ones which work 100% correct. I also heard good results from the latest intel drivers (git).

Roderick

[denis bonnenfant]

Roderick Colenbrander a écrit :
> > I tested git version with solidworks, and now it's worse than  with
> > previous chris patch :
> > - quite slow, just like with composite patch
> > - highlighted lines offset, just like with composite patch
> > - GLXbaddrawable crash when opening multiple windows, regression from
> >
> > the composite patch, that allows multiple windows
> >
> > It looks like all the previous issues are cumulated !
> >
> > maybe I missed something ?
> >
> > Denis
>
> What display drivers are you using? In general Nvidia's drivers are the only ones which work 100% correct. I also heard good results from the latest intel drivers (git).
>
> Roderick

proprietary nvidia up-to-date from ubuntu feisty, exactly the same that for .45 
or .45+patch tests. I switched off compiz, but it doesn't change anything

I just check sources from git, and ./configure && make depend && make && sudo 
make install, and then run /usr/local/bin/wine sldworks.exe

My libs are correct, as i can build ubuntu wine packages.

Denis