Re: d3dx9: Implementation of D3DXGetDeclLength

[H. Verbeet]

2008/8/5 Luis Busquets :
> +static const D3DVERTEXELEMENT9 lc={0xFF,0,D3DDECLTYPE_UNUSED,0,0,0};

What do you use this for?
> - while ((pdecl+i)->Stream!=0xFF)
> - {
> -
>    i++;

You might as well increment pdecl itself.

Also keep in mind that Alexandre won't be back before the 18th, so no
patches will be applied before that either.

d3dx9: Implementation of D3DXGetDeclLength

[Luis Busquets]

Certainly

+static const D3DVERTEXELEMENT9 lc={0xFF,0,D3DDECLTYPE_UNUSED,0,0,0};

is not used. I will take it out.

However, I do not understand why pdecl needs to be incremented. Actually, the tests respond correctly. Why do you think pdecl has to be incremented? We are actually returning i. pdecl is just an input.

Last, yeah I know. It is a pity. When I am on holiday is when I have more time...

H. Verbeet escribió:
> 2008/8/5 Luis Busquets :
> > +static const D3DVERTEXELEMENT9 lc={0xFF,0,D3DDECLTYPE_UNUSED,0,0,0};
>
> What do you use this for?
> > - while ((pdecl+i)->Stream!=0xFF)
> > - {
> > -
> >    i++;
>
> You might as well increment pdecl itself.
>
> Also keep in mind that Alexandre won't be back before the 18th, so no
> patches will be applied before that either.