Re: wine/dlls/commdlg printdlg.c

[Vitaly Lipatov]

В сообщении от 25 Август 2005 23:23 Alexandre Julliard написал(a):
> Log message:
>    Vitaly Lipatov 
>    Restore paper orientation when pagesetupdlg is initializing.
>
> Patch: http://cvs.winehq.org/patch.py?id=19818

Dear Alexandre!
You are removed dm checking for NULL... But it can be NULL in some cases...

<<<<<<< printdlg.c
        /* Set orientation radiobutton properly */
        dm = GlobalLock(pda->dlga->hDevMode);
        if (dm && dm->u1.s1.dmOrientation == DMORIENT_LANDSCAPE)
=======
        /* Set orientation radiobutton properly */
        dm = GlobalLock(pda->dlga->hDevMode);
        if (dm->u1.s1.dmOrientation == DMORIENT_LANDSCAPE)
> > > > > > > 1.93

wine/dlls/commdlg printdlg.c

[Alexandre Julliard]

Vitaly Lipatov  writes:
> Dear Alexandre!
> You are removed dm checking for NULL... But it can be NULL in some cases...

I didn't touch that bit, I'm afraid it was that way in your patch...