Re: ntdll: send_debug_event: don't send uninitialized bytes

[Robert Shearman]

Dan Kegel wrote:
> +/* Returns size of initialized part of a particular EXCEPTION_RECORD */
> +static int exception_record_size( const EXCEPTION_RECORD *rec )
> +{
> - return sizeof(*rec)
> -
> - (EXCEPTION_MAXIMUM_PARAMETERS-rec->NumberParameters) * sizeof(ULONG_PTR);
>
> +}

FIELD_OFFSET exists for this exact purpose.

ntdll: send_debug_event: don't send uninitialized bytes

[Dan Kegel]

On Nov 16, 2007 3:06 AM, Robert Shearman  wrote:
> > - return sizeof(*rec)
> > -
> > - (EXCEPTION_MAXIMUM_PARAMETERS-rec->NumberParameters) * sizeof(ULONG_PTR);
>
> FIELD_OFFSET exists for this exact purpose.

OK, I'll bite: is
+    return FIELD_OFFSET(EXCEPTION_RECORD, ExceptionInformation)
+    + rec->NumberParameters * sizeof(ULONG_PTR);
really clearer?
- Dan

ntdll: send_debug_event: don't send uninitialized bytes

[Robert Shearman]

Dan Kegel wrote:
> On Nov 16, 2007 3:06 AM, Robert Shearman  wrote:
> > > - return sizeof(*rec)
> > > -
> > > - (EXCEPTION_MAXIMUM_PARAMETERS-rec->NumberParameters) * sizeof(ULONG_PTR);
> >
> > FIELD_OFFSET exists for this exact purpose.
>
> OK, I'll bite: is
> - return FIELD_OFFSET(EXCEPTION_RECORD, ExceptionInformation)
> -
> - rec->NumberParameters * sizeof(ULONG_PTR);
>
> really clearer?

No, but this is:
    return FIELD_OFFSET(EXCEPTION_RECORD, 
ExceptionInformation[rec->NumberParameters]);