Huw Davies huw@codeweavers.com wrote:
case DirectColor:
X11DRV_PALETTE_PaletteFlags |= X11DRV_PALETTE_VIRTUAL;
- case GrayScale:
- case GrayScale: /* fall through */
case DirectColor: X11DRV_PALETTE_PaletteFlags |= X11DRV_PALETTE_VIRTUAL; /* fall through */ case GrayScale:
would be more clear IMHO. Right now it's not obvious to which case statement 'fall through' belongs to.
Same for other changes.
On Tue, Nov 27, 2012 at 06:44:35PM +0800, Dmitry Timoshkov wrote:
case DirectColor:
X11DRV_PALETTE_PaletteFlags |= X11DRV_PALETTE_VIRTUAL; /* fall through */ case GrayScale:
would be more clear IMHO. Right now it's not obvious to which case statement 'fall through' belongs to.
Resent, thanks.
Huw.