Re: winemp3.acm: Avoid using the long type.

[Chris Robinson]

On Friday, May 21, 2010 3:13:36 am Michael Stefaniuc wrote:
> @@ -191,7 +191,7 @@ static void mp3_horse(PACMDRVSTREAMINSTANCE adsi,
>      if (ret == MPG123_NEW_FORMAT)
>      {
> -
>        long rate;
> -
>        LONG_PTR rate;
>        int channels, enc;
>        mpg123_getformat(amd->mh, &rate, &channels, &enc);

I'm not sure this change is correct, when the function itself is expecting a 
pointer to an actual long.

winemp3.acm: Avoid using the long type.

[Michael Stefaniuc]

Chris Robinson wrote:
> On Friday, May 21, 2010 3:13:36 am Michael Stefaniuc wrote:
> > @@ -191,7 +191,7 @@ static void mp3_horse(PACMDRVSTREAMINSTANCE adsi,
> >      if (ret == MPG123_NEW_FORMAT)
> >      {
> > -
> >        long rate;
> > -
> >        LONG_PTR rate;
> >        int channels, enc;
> >        mpg123_getformat(amd->mh, &rate, &channels, &enc);
>
> I'm not sure this change is correct, when the function itself is expecting a 
> pointer to an actual long.

Yes, that's why I used LONG_PTR. That's the Win32 way of saying "I want
a real 'long' like everybody else is using" aka one that has the same
size as a pointer.

bye
    michael