Re: Xbox Controller no longer works in games

[Zebediah Figura]

On 18/08/18 10:56, Kai Krakow wrote:
> Hello again!
>
> 2018-08-18 17:00 GMT+02:00 Kai Krakow :
> > Hello!
> >
> > In 3.14, my Xbox controller no longer works in games. I bisected it
> > down to the following commit:
> > > 86d26dded5560d6d8adb195372f0676d1f7229b0 is the first bad commit
> > > commit 86d26dded5560d6d8adb195372f0676d1f7229b0
> > > Author: Zebediah Figura 
> > > Date:   Sun Jul 29 20:26:27 2018 -0500
> > >
> > > setupapi: Merge the InterfaceInfo and InterfaceInstances structs.
> > >
> > > It seems the original motivation for separating these was to facilitate easy
> > >   enumeration of specific classes using SetupDiEnumDeviceInterfaces(), but it
> > >   makes other things unnecessarily complex [including an eventual
> > >   implementation of SetupDiRemoveDeviceInterface()] and the implementation
> > >   provided here seems quite simple enough.
> > >
> > > Signed-off-by: Zebediah Figura 
> > >   Signed-off-by: Alexandre Julliard
> > >
> > > :040000 040000 a4dc0cce0367f6c43c4374f24f62f9131900cf90 320b4ec083b0ec393232cd47e51d5c1c5d4fc831 M      dlls
> >
> > After this commit, games no longer detect or respond to the gamepad.
> > In the logs, winebus.sys still finds the SDL device and enumerates the
> > controller.
> >
> > Apparently, this single commit is not easily revertible.
> >
> > Any clue how to fix this commit or support you in finding the problem?
>
> I've currently reverted a list of patches using:
>
> # git rev-list 86d26dded5560d6d8adb195372f0676d1f7229b0^..HEAD \
> #   dlls/setupapi/devinst.c | git revert --stdin
>
> This solves the problem for me.
>
> Thanks,
> Kai

Hello Kai,

I'd first file a bug on bugzilla, and second provide a log with
+setupapi,+plugplay. Thanks.

Xbox Controller no longer works in games

[Kai Krakow]

Hallo!

2018-08-18 18:05 GMT+02:00 Zebediah Figura :
> On 18/08/18 10:56, Kai Krakow wrote:
> > Hello again!
> >
> > 2018-08-18 17:00 GMT+02:00 Kai Krakow :
> > > Hello!
> > >
> > > In 3.14, my Xbox controller no longer works in games. I bisected it
> > > down to the following commit:
> > > > 86d26dded5560d6d8adb195372f0676d1f7229b0 is the first bad commit
> > > > commit 86d26dded5560d6d8adb195372f0676d1f7229b0
> > > > Author: Zebediah Figura 
> > > > Date:   Sun Jul 29 20:26:27 2018 -0500
> > > >
> > > > setupapi: Merge the InterfaceInfo and InterfaceInstances structs.
> > > >
> > > > It seems the original motivation for separating these was to facilitate easy
> > > >   enumeration of specific classes using SetupDiEnumDeviceInterfaces(), but it
> > > >   makes other things unnecessarily complex [including an eventual
> > > >   implementation of SetupDiRemoveDeviceInterface()] and the implementation
> > > >   provided here seems quite simple enough.
> > > >
> > > > Signed-off-by: Zebediah Figura 
> > > >   Signed-off-by: Alexandre Julliard
> > > >
> > > > :040000 040000 a4dc0cce0367f6c43c4374f24f62f9131900cf90 320b4ec083b0ec393232cd47e51d5c1c5d4fc831 M      dlls
> > >
> > > After this commit, games no longer detect or respond to the gamepad.
> > > In the logs, winebus.sys still finds the SDL device and enumerates the
> > > controller.
> > >
> > > Apparently, this single commit is not easily revertible.
> > >
> > > Any clue how to fix this commit or support you in finding the problem?
> >
> > I've currently reverted a list of patches using:
> >
> > # git rev-list 86d26dded5560d6d8adb195372f0676d1f7229b0^..HEAD \
> > #   dlls/setupapi/devinst.c | git revert --stdin
> >
> > This solves the problem for me.
> >
> > Thanks,
> > Kai
>
> Hello Kai,
>
> I'd first file a bug on bugzilla, and second provide a log with
> +setupapi,+plugplay. Thanks.

I see you've sent a fix for this already before I had a chance to file
a bug report. I'll look into it soon and let you know if it fixes the
problem for me.

Thanks,
Kai