Re: winmm: Increase tolerance range in tests

[Robert Reif]

Alistair Leslie-Hughes wrote:
> Hi,
>
> Changelog:
>     winmm: Increase tolerance range in tests
>
> Best Regards
>  Alistair Leslie-Hughes

Please give an explanation why?  If it's just to make the test pass, 
then we need to know why the test is failing.

Is it only needed for wine?  Could be a wine problem.

Is it only needed for specific versions of Windows or specific hardware 
or drivers?

Is it only needed for Windows running on a virtual machine?  Then it 
could be a a virtual machine hardware emulation problem.

I think all Windows hardware test failures that only happen on virtual 
machines should be considered suspect.  It would be nice to detect if 
Windows is running on real hardware or a virtual machine because of this 
type of problem.

winmm: Increase tolerance range in tests

[Maarten Lankhorst]

Hi Robert,

2008/11/5, Robert Reif :
> Alistair Leslie-Hughes wrote:
> > Hi,
> >
> > Changelog:
> >     winmm: Increase tolerance range in tests
> >
> > Best Regards
> >  Alistair Leslie-Hughes
>
> Please give an explanation why?  If it's just to make the test pass,
> then we need to know why the test is failing.
>
> Is it only needed for wine?  Could be a wine problem.
>
> Is it only needed for specific versions of Windows or specific hardware
> or drivers?
>
> Is it only needed for Windows running on a virtual machine?  Then it
> could be a a virtual machine hardware emulation problem.
>
> I think all Windows hardware test failures that only happen on virtual
> machines should be considered suspect.  It would be nice to detect if
> Windows is running on real hardware or a virtual machine because of this
> type of problem.

As far as I understand it all winmm tests are dependant on the drivers
being used, you will get different failures for a sound blaster then
you would get if you have an intel hda chipset.

Cheers,
Maarten.

winmm: Increase tolerance range in tests

[Alistair Leslie-Hughes]

Robert Reif wrote:
> Please give an explanation why?  If it's just to make the test pass, 
> then we need to know why the test is failing.
>
> Is it only needed for wine?  Could be a wine problem.
>
> Is it only needed for specific versions of Windows or specific hardware 
> or drivers?
>
> Is it only needed for Windows running on a virtual machine?  Then it 
> could be a a virtual machine hardware emulation problem.
>
> I think all Windows hardware test failures that only happen on virtual 
> machines should be considered suspect.  It would be nice to detect if 
> Windows is running on real hardware or a virtual machine because of this 
> type of problem.

Hi Robert,
   It was mainly to get test to pass.

Its appears from the testing data that XP, 2k3, vista, 2k8 all have
issues with the tolerance values.

Best Regards
  Alistair Leslie-Hughes

winmm: Increase tolerance range in tests

[Robert Reif]

Alistair Leslie-Hughes wrote:
> Robert Reif wrote:
> > Please give an explanation why?  If it's just to make the test pass, 
> > then we need to know why the test is failing.
> >
> > Is it only needed for wine?  Could be a wine problem.
> >
> > Is it only needed for specific versions of Windows or specific hardware 
> > or drivers?
> >
> > Is it only needed for Windows running on a virtual machine?  Then it 
> > could be a a virtual machine hardware emulation problem.
> >
> > I think all Windows hardware test failures that only happen on virtual 
> > machines should be considered suspect.  It would be nice to detect if 
> > Windows is running on real hardware or a virtual machine because of this 
> > type of problem.
>
> Hi Robert,
>    It was mainly to get test to pass.
>
> Its appears from the testing data that XP, 2k3, vista, 2k8 all have
> issues with the tolerance values.
>
> Best Regards
>   Alistair Leslie-Hughes

On real hardware or on a virtual machine?

winmm: Increase tolerance range in tests

[Jeff Zaroyko]

On Thu, Nov 6, 2008 at 11:00 PM, Robert Reif  wrote:
> Alistair Leslie-Hughes wrote:
> > Robert Reif wrote:
> > > Please give an explanation why?  If it's just to make the test pass,
> > > then we need to know why the test is failing.
> > >
> > > Is it only needed for wine?  Could be a wine problem.
> > >
> > > Is it only needed for specific versions of Windows or specific hardware
> > > or drivers?
> > >
> > > Is it only needed for Windows running on a virtual machine?  Then it
> > > could be a a virtual machine hardware emulation problem.
> > >
> > > I think all Windows hardware test failures that only happen on virtual
> > > machines should be considered suspect.  It would be nice to detect if
> > > Windows is running on real hardware or a virtual machine because of this
> > > type of problem.
> >
> > Hi Robert,
> >    It was mainly to get test to pass.
> >
> > Its appears from the testing data that XP, 2k3, vista, 2k8 all have
> > issues with the tolerance values.
> >
> > Best Regards
> >   Alistair Leslie-Hughes
>
> On real hardware or on a virtual machine?

I have real hardware that the tolerance is slightly out for on
Windows, snd_hda_intel:
wave.c:797: Test failed: The sound played for 1125 ms instead of 1000 ms

-Jeff