Re: [PATCH 1/2] joystick.cpl: First version of the joystick configuration applet

[Alexandre Julliard]

Lucas Fialho Zawacki  writes:
> From: Lucas Fialho Zawacki
>
> This adds a control panel applet to configure the joysticks. It is
> a property sheet and has 3 pages:
> - Joystick listing
> - Axes and Button Testing
> - Force Feedback testing
>
> All the function are stubs at the moment, the panel has no icon too.
>
> configure.ac                        |    1 +
>  dlls/joystick.cpl/Makefile.in       |   14 +++
>  dlls/joystick.cpl/forcefeedback.c   |   60 +++++++++++
>  dlls/joystick.cpl/joystick.cpl.spec |    3 +
>  dlls/joystick.cpl/joystick.h        |   63 ++++++++++++
>  dlls/joystick.cpl/joystick.rc       |   55 ++++++++++
>  dlls/joystick.cpl/list.c            |   57 +++++++++++
>  dlls/joystick.cpl/main.c            |  191 +++++++++++++++++++++++++++++++++++
>  dlls/joystick.cpl/test.c            |   60 +++++++++++
>  9 files changed, 504 insertions(+)
>  create mode 100644 dlls/joystick.cpl/Makefile.in
>  create mode 100644 dlls/joystick.cpl/forcefeedback.c
>  create mode 100644 dlls/joystick.cpl/joystick.cpl.spec
>  create mode 100644 dlls/joystick.cpl/joystick.h
>  create mode 100644 dlls/joystick.cpl/joystick.rc
>  create mode 100644 dlls/joystick.cpl/list.c
>  create mode 100644 dlls/joystick.cpl/main.c
>  create mode 100644 dlls/joystick.cpl/test.c

It's called joy.cpl on Windows. Please also use compatible exports, and
avoid creating a lot of empty source files. I'd expect that a single
source file is sufficient for this.

[PATCH 1/2] joystick.cpl: First version of the joystick configuration applet

[Lucas Zawacki]

> It's called joy.cpl on Windows. Please also use compatible exports, and
> avoid creating a lot of empty source files. I'd expect that a single
> source file is sufficient for this.

Will do. I removed the uneeded shlwapi and advapi32 from the exports
is that enough or am I missing something?

[PATCH 1/2] joystick.cpl: First version of the joystick configuration applet

[Alexandre Julliard]

Lucas Zawacki  writes:
> > It's called joy.cpl on Windows. Please also use compatible exports, and
> > avoid creating a lot of empty source files. I'd expect that a single
> > source file is sufficient for this.
>
> Will do. I removed the uneeded shlwapi and advapi32 from the exports
> is that enough or am I missing something?

I mean the functions you export in the spec file.