Re: crypt32: implement CryptSIPLoad (resend)

[Alexandre Julliard]

Juan Lang  writes:
> Hi, any problems with this one?

It's causing test failures:

../../../tools/runtest -q -P wine -M rsaenh.dll -T ../../.. -p rsaenh_test.exe.so rsaenh.c && touch rsaenh.ok
rsaenh.c:64: Test failed: 0, 00000057
rsaenh.c:68: Test failed: 00000057
make: *** [rsaenh.ok] Error 2

crypt32: implement CryptSIPLoad (resend)

[Juan Lang]

> It's causing test failures:
>
> ../../../tools/runtest -q -P wine -M rsaenh.dll -T ../../.. -p
> rsaenh_test.exe.so rsaenh.c && touch rsaenh.ok
> rsaenh.c:64: Test failed: 0, 00000057
> rsaenh.c:68: Test failed: 00000057
> make: *** [rsaenh.ok] Error 2

How very odd, those failures aren't anywhere in the code path modified by
this.  In fact, crypt32 shouldn't even be loaded at that point in the
tests:  the failing calls are through advapi32 to rsaenh, and crypt32
isn't loaded explicitly or implicitly by the tests.

Are you sure there isn't something else going on?
--Juan

____________________________________________________________________________________Pinpoint customers who are looking for what you sell. 
http://searchmarketing.yahoo.com/

crypt32: implement CryptSIPLoad (resend)

[Alexandre Julliard]

Juan Lang  writes:
> > It's causing test failures:
> >
> > ../../../tools/runtest -q -P wine -M rsaenh.dll -T ../../.. -p
> > rsaenh_test.exe.so rsaenh.c && touch rsaenh.ok
> > rsaenh.c:64: Test failed: 0, 00000057
> > rsaenh.c:68: Test failed: 00000057
> > make: *** [rsaenh.ok] Error 2
>
> How very odd, those failures aren't anywhere in the code path modified by
> this.  In fact, crypt32 shouldn't even be loaded at that point in the
> tests:  the failing calls are through advapi32 to rsaenh, and crypt32
> isn't loaded explicitly or implicitly by the tests.

Crypt32 is imported by rsaenh, so it is loaded.

At first glance the problem is probably around your use of
DuplicateHandle on a module handle, that cannot work.

crypt32: implement CryptSIPLoad (resend)

[Juan Lang]

> Crypt32 is imported by rsaenh, so it is loaded.
>
> At first glance the problem is probably around your use of
> DuplicateHandle on a module handle, that cannot work.

Ah.  Thanks, I overlooked both of those things, sorry for that.
--Juan

____________________________________________________________________________________Building a website is a piece of cake. Yahoo! Small Business gives you all the tools to get online.
http://smallbusiness.yahoo.com/webhosting