Status on SetPixelFormat patch from May 2010

[Jeff Cook]

Hello all

I am curious about the patch on
http://bugs.winehq.org/show_bug.cgi?id=18490 and why it's not in
vanilla. http://bugs.winehq.org/show_bug.cgi?id=18490#c9 seems to be a
pretty cogent explanation of the issue and the patch appears
reasonable enough. It prevents a major crasher in Empire: Total War,
which otherwise works really well. Maybe it was just never submitted
to wine-patches?

Thanks
Jeff

[Chris Robinson]

On Friday, December 30, 2011 1:41:12 PM Jeff Cook wrote:
> Hello all
>
> I am curious about the patch on
> http://bugs.winehq.org/show_bug.cgi?id=18490 and why it's not in
> vanilla. http://bugs.winehq.org/show_bug.cgi?id=18490#c9 seems to be a
> pretty cogent explanation of the issue and the patch appears
> reasonable enough.

Because it's not correct. OpenGL's SetPixelFormat on the desktop window 
(GetDC(0)) is supposed to fail, or at least did when I made tests for it a few 
years ago. I think a better fix would be for wined3d to use a dummy surface, 
or a renderless context (available with OpenGL 3.0), if it's asked to use the 
desktop window.

[Henri Verbeet]

On 30 December 2011 22:15, Chris Robinson  wrote:
> years ago. I think a better fix would be for wined3d to use a dummy surface,
> or a renderless context (available with OpenGL 3.0), if it's asked to use the
> desktop window.

Yes, we do something along those lines in ddraw, and we'll likely move
it to wined3d after 1.4.

[Jeff Cook]

On Fri, Dec 30, 2011 at 11:43 PM, Henri Verbeet  wrote:
> On 30 December 2011 22:15, Chris Robinson  wrote:
> > years ago. I think a better fix would be for wined3d to use a dummy surface,
> > or a renderless context (available with OpenGL 3.0), if it's asked to use the
> > desktop window.
>
> Yes, we do something along those lines in ddraw, and we'll likely move
> it to wined3d after 1.4.

Do you mind going into more detail on the motive for waiting for 1.4?
I was under the impression that WINE didn't usually postpone big
changes until an rc series was ongoing or at least anticipated. Is
there discussion of starting the 1.4 RC phase soon, and that's the
motive for holding off? I am just curious to know why you're waiting.

[Henri Verbeet]

On 31 December 2011 12:51, Jeff Cook  wrote:
> Do you mind going into more detail on the motive for waiting for 1.4?
> I was under the impression that WINE didn't usually postpone big
> changes until an rc series was ongoing or at least anticipated. Is
> there discussion of starting the 1.4 RC phase soon, and that's the
> motive for holding off? I am just curious to know why you're waiting.

Yes, I'd expect a freeze fairly soon. This change would be part of a
larger set of changes to make wined3d work properly without a window
to render to, and would probably be fairly invasive.