Apps with problems during install using Managed Mode

[Carlos Lozano]

Hello,

I have been checking some apps what had problems in order
to install in Managed Mode (due to background above the
continue window) and after of apply the change what i sent 
yesterday it started to work. With luck it should work for
every Installshield app. Now the question:

Do you know more apps with problems installing in managed mode?

Thanks.
Regards,
Carlos.

Pd: it is the change:

dlls/x11drv/windows.c

inline static BOOL is_window_managed( WND *win )
{
    if (!managed_mode) return FALSE;
    /* tray window is always managed */
    if (win->dwExStyle & WS_EX_TRAYWINDOW) return TRUE;
    /* child windows are not managed */                
    if (win->dwStyle & WS_CHILD) return FALSE;
    /* tool windows are not managed */
    if (win->dwExStyle & WS_EX_TOOLWINDOW) return FALSE;
    /* windows with caption or thick frame are managed */
    if ((win->dwStyle & WS_CAPTION) == WS_CAPTION) return TRUE;
    if (win->dwStyle & WS_THICKFRAME) return TRUE;

/**************** New code *****************************/
    if ((win->dwStyle & (WS_CLIPSIBLINGS|WS_CLIPCHILDREN) ) ==
        (WS_CLIPSIBLINGS|WS_CLIPCHILDREN))
           return TRUE;
    /************** End new code ***************************/

/* default: not managed */
    return FALSE;
}

[Gerhard W. Gruber]

On Thu, 29 May 2003 15:53:56 +0200, Carlos Lozano  wrote:
> I have been checking some apps what had problems in order
> to install in Managed Mode (due to background above the
> continue window) and after of apply the change what i sent 
> yesterday it started to work. With luck it should work for
> every Installshield app. Now the question:
>
> Do you know more apps with problems installing in managed mode?

Can you provide a list of apps that you tested? I know that DarkProject 2 hung
on install and I know another app as well, but I don't remeber which one that
was. I can try several of course.
> inline static BOOL is_window_managed( WND *win )

This is the patch? Then I'll apply it and test some things.

[Carlos Lozano]

El jue, 29 de may de 2003, a las 17:23, Gerhard W. Gruber escribio:
> On Thu, 29 May 2003 15:53:56 +0200, Carlos Lozano  wrote:
> > I have been checking some apps what had problems in order
> > to install in Managed Mode (due to background above the
> > continue window) and after of apply the change what i sent 
> > yesterday it started to work. With luck it should work for
> > every Installshield app. Now the question:
> >
> > Do you know more apps with problems installing in managed mode?
>
> Can you provide a list of apps that you tested? I know that DarkProject 2 hung
> on install and I know another app as well, but I don't remeber which one that
> was. I can try several of course.

It were 5 apps (vampire demo, theme hospital demo, praetorima demo,
vtd amaril installer, and other game what i don't remember the name),
but everyone was Installshield, so i guest that installshield 
should install correctly now. The question is: does it break any
different app?
> > inline static BOOL is_window_managed( WND *win )
>
> This is the patch? Then I'll apply it and test some things.

Yes, it is not really a diff (i will send it if someone need it), 
anyway only add this 3 lines in that function, it should be ok to
test.

Regards,
Carlos.

[Mark Westcott]

Hi,

I'm not 100% sure this is right, just because a window has WS_CLIPSIBLINGS and 
WS_CLIPCHILDREN does not mean we necessarily want to manage it.

For example, both Trillian and WinAmp set this combination, and these need to 
be unmanaged (ideally semi managed I think, where we draw the system bar, let 
the app clip it away, then hand over to the window manager setting hints for 
no decoration.. but thats another matter)

But then again I may be talking rubbish,

Mark
> inline static BOOL is_window_managed( WND *win )
> {
>     if (!managed_mode) return FALSE;
>     /* tray window is always managed */
>     if (win->dwExStyle & WS_EX_TRAYWINDOW) return TRUE;
>     /* child windows are not managed */
>     if (win->dwStyle & WS_CHILD) return FALSE;
>     /* tool windows are not managed */
>     if (win->dwExStyle & WS_EX_TOOLWINDOW) return FALSE;
>     /* windows with caption or thick frame are managed */
>     if ((win->dwStyle & WS_CAPTION) == WS_CAPTION) return TRUE;
>     if (win->dwStyle & WS_THICKFRAME) return TRUE;
> /**************** New code *****************************/
> if ((win->dwStyle & (WS_CLIPSIBLINGS|WS_CLIPCHILDREN) ) ==
>     (WS_CLIPSIBLINGS|WS_CLIPCHILDREN))
>        return TRUE;
> /************** End new code ***************************/
>
> /* default: not managed */
> return FALSE;
>
> }

[Carlos Lozano]

Hello,
> I'm not 100% sure this is right, just because a window has WS_CLIPSIBLINGS 
> and WS_CLIPCHILDREN does not mean we necessarily want to manage it.
>
> For example, both Trillian and WinAmp set this combination, and these need to 
> be unmanaged (ideally semi managed I think, where we draw the system bar, let 
> the app clip it away, then hand over to the window manager setting hints for 
> no decoration.. but thats another matter)

I don't know even what means "WS_CLIPSIBLINGS" and "WS_CLIPCHILDREN" ;)
I have been searching a way to install this applications, using managed
mode O:-)

Regards,
Carlos.

[Mike Hearn]

It is not that simple. I'm pretty sure that change would break many
other apps.

Being able to install apps in managed mode requires deep knowledge and
hacks of the x11drv, it is on the Wine 0.9 TODO list. Alexandre has
discussed it before, this is not a simple bug by any means :(

So, thanks for your efforts, but I'm not sure this is the correct
solution.

On Thu, 2003-05-29 at 17:28, Carlos Lozano wrote:
> Hello,
> > I'm not 100% sure this is right, just because a window has WS_CLIPSIBLINGS 
> > and WS_CLIPCHILDREN does not mean we necessarily want to manage it.
> >
> > For example, both Trillian and WinAmp set this combination, and these need to 
> > be unmanaged (ideally semi managed I think, where we draw the system bar, let 
> > the app clip it away, then hand over to the window manager setting hints for 
> > no decoration.. but thats another matter)
>
> I don't know even what means "WS_CLIPSIBLINGS" and "WS_CLIPCHILDREN" ;)
> I have been searching a way to install this applications, using managed
> mode O:-)
>
> Regards,
> Carlos.

[Carlos Lozano]

El jue, 29 de may de 2003, a las 18:14, Mike Hearn escribio:
> It is not that simple. I'm pretty sure that change would break many
> other apps.
>
> Being able to install apps in managed mode requires deep knowledge and
> hacks of the x11drv, it is on the Wine 0.9 TODO list. Alexandre has
> discussed it before, this is not a simple bug by any means :(
>
> So, thanks for your efforts, but I'm not sure this is the correct
> solution.

I think that the question is check if it is better than the actual,
and if it is, then move to it. Sure that it is not 100%, but if it hasn't
bad side effects, then it could delay a bit more the x11drv rewrite, and
have more time for other changes.

Regards,
Carlos.

[Z_God]

Op donderdag 29 mei 2003 19:14, schreef Mike Hearn:
> Being able to install apps in managed mode requires deep knowledge and
> hacks of the x11drv, it is on the Wine 0.9 TODO list. Alexandre has
> discussed it before, this is not a simple bug by any means :(

To be able to use those installers properly, maybe it would be easier to 
change the current unmanaged mode so that apps still integrate with the 
desktop environment (they have a button on the panel to which the minimize, 
etc.) but are not completely managed. (Similar the Xmms for example maybe?) 
Just a suggestion.

[Carlos Lozano]

El jue, 29 de may de 2003, a las 17:14, Mark Westcott escribio:
> Hi,
>
> I'm not 100% sure this is right, just because a window has WS_CLIPSIBLINGS and 
> WS_CLIPCHILDREN does not mean we necessarily want to manage it.
>
> For example, both Trillian and WinAmp

Hmm, i don't see any different between WinAmp with the patch, and WimAmp
without the patch.

Regards,
Carlos.