Dimitrie O. Paun wrote:
Bottom line, since the change is free (the work is done by a script), and there is little chance of conflicts with other patches (it touches only the include statements), I think it's worth doing now.
There is one downside: it may make old patches harder to apply, and it may make it harder to sync with other trees (e.g. rewind).
On the other hand, encouraging people to use the tool to tidy up any files they're working on makes patches harder to read, as it mixes formatting changes with real changes.
Six of one, half dozen of another... - Dan
On January 2, 2003 02:07 pm, Dan Kegel wrote:
There is one downside: it may make old patches harder to apply, and it may make it harder to sync with other trees (e.g. rewind).
In general yes, but I don't think it's a big problem in this particular case where _only_ #include statements are touched. These are seldomly changed anyway. As for other trees, all of Patrik work is BSD AFAIK, so everybody can run the script on their trees as well.
While we are on the subject of api_check and such, how about changing SUBLANG_NEUTRAL in all non-neutral languages to SUBLANG_DEFAULT, as it should be?
Sh.
Dimitrie O. Paun wrote:
On January 2, 2003 02:07 pm, Dan Kegel wrote:
There is one downside: it may make old patches harder to apply, and it may make it harder to sync with other trees (e.g. rewind).
In general yes, but I don't think it's a big problem in this particular case where _only_ #include statements are touched. These are seldomly changed anyway. As for other trees, all of Patrik work is BSD AFAIK, so everybody can run the script on their trees as well.
On January 2, 2003 04:05 pm, Shachar Shemesh wrote:
While we are on the subject of api_check and such, how about changing SUBLANG_NEUTRAL in all non-neutral languages to SUBLANG_DEFAULT, as it should be?
Are you volunteering? :) If it's supposed to be this way, a patch would be most appreciated, me thinks <g>
-
Dan Kegel -
Dimitrie O. Paun -
Shachar Shemesh