Re: [winecfg 2] Merge X11DRV dialog code from Mark, bugfixes

[Dimitrie O. Paun]

On 27 Aug 2003, Mike Hearn wrote:
> - Merge X11DRV dialog code from Mark
> - Move X11DRV dialog init code to a separate file
> - Link with Xlib to get XParseGeometry

--- /dev/null   2003-01-30 10:24:37.000000000 +0000
+++ programs/winecfg/x11drvdlg.h        2003-08-26 23:16:32.000000000 +0100
@@ -0,0 +1,10 @@
+#ifndef X11DRVDLG_H
+#define X11DRVDLG_H
+
+#include "winecfg.h"
+
+void initX11DrvDlg (HWND hDlg);
+void saveX11DrvDlgSettings (HWND hDlg);
+INT_PTR CALLBACK X11DrvDlgProc (HWND hDlg, UINT uMsg, WPARAM wParam, LPARAM lParam);
+
+#endif

Do we really need a separate .h file for this? It just seems we make the thing
a lot more complicated than needed...

[winecfg 2] Merge X11DRV dialog code from Mark, bugfixes

[Mike Hearn]

On Wed, 2003-08-27 at 15:50, Dimitrie O. Paun wrote:
> Do we really need a separate .h file for this? It just seems we make the thing
> a lot more complicated than needed...

I don't know to be honest, that's just how the code was written that I
merged in. Later on it might be used more....

Basically the only changes I made were code style/formatting, updating
to the new names, and splitting initX11DrvDlg() so it all the config
file loading code was moved to loadConfig().

[winecfg 2] Merge X11DRV dialog code from Mark, bugfixes

[Dimitrie O. Paun]

On 27 Aug 2003, Mike Hearn wrote:
> I don't know to be honest, that's just how the code was written that I
> merged in. Later on it might be used more....

I doubt. I'd rather split things in the future if need be than
overengineer things. And since you took on the task of merging
things, I was hoping to avoid introducing unnecessary files.