Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32. (try 7 resend)
Charles Davis cdavis@mymail.mines.edu writes:
Rebased against Marcus Meissner's DECLSPEC_HIDDEN patches. (I hate you, Marcus...) Try 7: Fix getting the device name for IDE devices. Try 6: Fix some problems noticed by Vitaliy Margolen. Try 5: Get the value of "DeviceName" from mountmgr instead of making one up. Try 4: Fix unused variable warning. Try 3: Add support for IDE drives. Try 2: Don't depend on the SCSI generic driver on Linux.
The unix device name is not being set properly here. I would consider not setting the key a feature (we don't really need it), but it means the DMA flag isn't set either.
On 5/23/11 12:15 PM, Alexandre Julliard wrote:
Charles Davis cdavis@mymail.mines.edu writes:
Rebased against Marcus Meissner's DECLSPEC_HIDDEN patches. (I hate you, Marcus...) Try 7: Fix getting the device name for IDE devices. Try 6: Fix some problems noticed by Vitaliy Margolen. Try 5: Get the value of "DeviceName" from mountmgr instead of making one up. Try 4: Fix unused variable warning. Try 3: Add support for IDE drives. Try 2: Don't depend on the SCSI generic driver on Linux.
The unix device name is not being set properly here. I would consider not setting the key a feature (we don't really need it), but it means the DMA flag isn't set either.
The problem is that Wine's winaspi/wnaspi32 is using the UnixDeviceName key. The way it uses it, it expects a SCSI generic device (/dev/sg*). That's why I set it to the /dev/sg* device if it's present, and don't set it otherwise.
Most modern programs should be using SPTI instead of ASPI, though a few older programs from the Windows 9x era might still use ASPI. Do you want to rip out WinASPI support?
Chip
Charles Davis cdavis@mymail.mines.edu writes:
The problem is that Wine's winaspi/wnaspi32 is using the UnixDeviceName key. The way it uses it, it expects a SCSI generic device (/dev/sg*). That's why I set it to the /dev/sg* device if it's present, and don't set it otherwise.
Most modern programs should be using SPTI instead of ASPI, though a few older programs from the Windows 9x era might still use ASPI. Do you want to rip out WinASPI support?
No, but it shouldn't depend on the Unix device name, it should do ioctls on the Win32 device. But that's an unrelated change of course. Note that I don't get a Unix device for my /dev/sg0 device either.
-
Alexandre Julliard -
Charles Davis