Re: shdocvw: Fix test for non-english IE MUI

[Jacek Caban]

Hi Alistair,

Alistair Leslie-Hughes wrote:
> Hi,
>   Either use this patch or patch "Added support for non-enligh IE MUI".
>
> Changelog:
>     shdocvw: Fix test for non-english IE MUI

-    ok(!strcmp_wa(sName, "Microsoft Web Browser Control"), "got '%s', expected 'Microsoft Web Browser Control'\n", wine_dbgstr_w(sName));
+    ok(sName, "get_Name return a NULL string.'\n");

You don't need to delete the whole test. You can check for the system language and do the compare only if it's English.

Jacek

shdocvw: Fix test for non-english IE MUI

[Alistair Leslie-Hughes]

Hi Jacek,
> You don't need to delete the whole test. You can check for the system 
> language and do the compare only if it's English.

Is there an example that already does this?

Just use function GetUILanguageInfo or similar?

Best Regards
 Alistair Leslie-Hughes

shdocvw: Fix test for non-english IE MUI

[Paul Vriens]

On 12/08/2009 01:29 PM, Alistair Leslie-Hughes wrote:
> Hi Jacek,
> > You don't need to delete the whole test. You can check for the system
> > language and do the compare only if it's English.
>
> Is there an example that already does this?
>
> Just use function GetUILanguageInfo or similar?
>
> Best Regards
> Alistair Leslie-Hughes

Something like (advapi32/test/security.c):

if (PRIMARYLANGID(LANGIDFROMLCID(GetThreadLocale())) != LANG_ENGLISH)
     {
         skip("Non-english locale (test with hardcoded 'Everyone')\n");
     }