Alistair Leslie-Hughes wrote:
Hi,
Changelog: shdocvw: Added Support for the IViewObjectEx interface
Please check if interface you add is really supposed to be there. It's not the first time someone tries to add an interface to WebBrowser or HTMLDocument that shouldn't be there (this time the patch is already in Git). Please remember that the fact that an app queries for interface doesn't mean it should success! I keep adding tests for such cases, but it really easy to tests it before sending patch and it's something you *should* do.
Jacek
Jacek Caban wrote:
Alistair Leslie-Hughes wrote:
Hi,
Changelog: shdocvw: Added Support for the IViewObjectEx interface
Please check if interface you add is really supposed to be there. It's not the first time someone tries to add an interface to WebBrowser or HTMLDocument that shouldn't be there (this time the patch is already in Git). Please remember that the fact that an app queries for interface doesn't mean it should success! I keep adding tests for such cases, but it really easy to tests it before sending patch and it's something you *should* do.
Hi Jacek, I have been guilty of trying to add interfaces incorrectly here. I did double check on windows to confirm this interface does exist. I will add some test cases shortly.
Best Regards Alistair Leslie-Hughes
Jacek Caban wrote:
Alistair Leslie-Hughes wrote:
Hi,
Changelog: shdocvw: Added Support for the IViewObjectEx interface
Please check if interface you add is really supposed to be there. It's not the first time someone tries to add an interface to WebBrowser or HTMLDocument that shouldn't be there (this time the patch is already in Git). Please remember that the fact that an app queries for interface doesn't mean it should success! I keep adding tests for such cases, but it really easy to tests it before sending patch and it's something you *should* do.
Hi Jacek, Thanks for the correction. I had submitted a patch to provide this interface doesn't exist. Once this is reverted, I silence that interface warning.
Best Regards Alistair Leslie-Hughes
-
Alistair Leslie-Hughes -
Jacek Caban