Re: gdi/mfdrv BS_PATTERN brushes

[Huw D M Davies]

On Mon, Nov 29, 2004 at 09:16:49PM -0800, Walt Ogburn wrote:
> This fixes the problem that Emanuele Gisi reported last month in the Aloha
> problem.  With this patch BS_PATTERN brushes get created correctly and
> don't cause a locking problem.
>
> Changelog:
> Fix creation of BS_PATTERN brushes in mfdrv
> Index: dlls/gdi/mfdrv/objects.c
>
> RCS file: /home/wine/wine/dlls/gdi/mfdrv/objects.c,v
> retrieving revision 1.14
> diff -u -r1.14 objects.c
> --- dlls/gdi/mfdrv/objects.c    22 Nov 2004 18:19:59 -0000      1.14
> +++ dlls/gdi/mfdrv/objects.c    30 Nov 2004 06:10:03 -0000
> -
>       mr->rdFunction = META_DIBCREATEPATTERNBRUSH;
> -
>       mr->rdFunction = META_CREATEPATTERNBRUSH;

Does a BS_PATTERN brush really create a META_CREATEPATTERNBRUSH record
under Windows?

Huw.

gdi/mfdrv BS_PATTERN brushes

[Walt Ogburn]

Hi Huw,

You're right, it's a META_DIBCREATEPATERNBRUSH under XP at least.  I think
I understand this better now.  I'll hold off on the patch and try to write
some tests.  I don't think there's any easy way to fix the problems in the
current code without changing it to META_CREATEPATTERNBRUSH.

Thanks.
Walter

On Tue, 30 Nov 2004, Huw D M Davies wrote:
> On Mon, Nov 29, 2004 at 09:16:49PM -0800, Walt Ogburn wrote:
> > This fixes the problem that Emanuele Gisi reported last month in the Aloha
> > problem.  With this patch BS_PATTERN brushes get created correctly and
> > don't cause a locking problem.
> >
> > Changelog:
> > Fix creation of BS_PATTERN brushes in mfdrv
> > Index: dlls/gdi/mfdrv/objects.c
> >
> > RCS file: /home/wine/wine/dlls/gdi/mfdrv/objects.c,v
> > retrieving revision 1.14
> > diff -u -r1.14 objects.c
> > --- dlls/gdi/mfdrv/objects.c    22 Nov 2004 18:19:59 -0000      1.14
> > +++ dlls/gdi/mfdrv/objects.c    30 Nov 2004 06:10:03 -0000
> > -
> >       mr->rdFunction = META_DIBCREATEPATTERNBRUSH;
> > -
> >       mr->rdFunction = META_CREATEPATTERNBRUSH;
>
> Does a BS_PATTERN brush really create a META_CREATEPATTERNBRUSH record
> under Windows?
> Huw.
>
> Huw Davies
> [e-mail]