It's pretty unlikely that count would be larger than 0xffffffff.
I agree, but i thought we should mimic Windows-behaviour, and the tests showed that such large values are at least allowed. If this value is too large could you suggest another one?
Also I don't think we need a version check.
The check is there as the tests show that there is a difference between ver < win98 and ver > WINNT. I don't know if there a are applications that depend on this difference really. Anyway, i could return something like min(65536,count) for all versions, is that ok? (i'll strip out the tests then, as they won't be passing then anymore)
Louis Lenders wrote:
It's pretty unlikely that count would be larger than 0xffffffff.
I agree, but i thought we should mimic Windows-behaviour, and the tests showed that such large values are at least allowed. If this value is too large could you suggest another one?
I know I'm spoiling Alexandre's teaching attempt but I couldn't resist... 0xffffffff is UINT_MAX thus min( 0xffffffff, count ) == count
Also I don't think we need a version check.
The check is there as the tests show that there is a difference between ver < win98 and ver > WINNT. I don't know if there a are applications that depend on this difference really. Anyway, i could return something like min(65536,count) for all versions, is that ok? (i'll strip out the tests then, as they won't be passing then anymore)
bye michael
Hi Louis,
The check is there as the tests show that there is a difference between ver < win98 and ver > WINNT. I don't know if there a are applications that depend on this difference really. Anyway, i could return something like min(65536,count) for all versions, is that ok? (i'll strip out the tests then, as they won't be passing then anymore)
It's true that there is, but I don't think it's all that relevant. The main raison d'etre for this function is for Win32s, if MSDN is to be believed, and its function is to work around a default OS limitation. Since we don't have the same limitation in Wine, applications can call it or not, but it won't have any effect. Hence maintaining a version-dependent external behavior, while not behaving differently internally, doesn't make sense to me. --Juan
-
Juan Lang -
Louis Lenders -
Michael Stefaniuc