Re: [PATCH] scrrun: Implement WriteLine/Write for ITextStream (try2)

[Dmitry Timoshkov]

Nikolay Sivov  wrote:
> +static HRESULT textstream_writestr(struct textstream *stream, BSTR text)
> +{
> - DWORD written = 0;
> - BOOL ret;
> -
> - if (stream->unicode) {
> -
>    if (stream->first_write) {
> -
>        static const short utf16bom = 0xfeff;

'WCHAR' instead of 'short' would look more natural IMO, especially since
remaining data is WCHAR based..

[PATCH] scrrun: Implement WriteLine/Write for ITextStream (try2)

[Nikolay Sivov]

On 3/18/2014 12:28, Dmitry Timoshkov wrote:
> Nikolay Sivov  wrote:
> > +static HRESULT textstream_writestr(struct textstream *stream, BSTR text)
> > +{
> > - DWORD written = 0;
> > - BOOL ret;
> > -
> > - if (stream->unicode) {
> > -
> >    if (stream->first_write) {
> > -
> >        static const short utf16bom = 0xfeff;
>
> 'WCHAR' instead of 'short' would look more natural IMO, especially since
> remaining data is WCHAR based..

I don't think it's really important.