Re: ReadFile speedup

[Hannu Kotipalo]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Eric Pouech kirjoitti Tiistai 12. Marraskuuta 2002 23:50:
> just a dumb question: shouldn't we better (for synchronous unix reads)
> convert the fd into a FILE* (cache those FILEs for a few streams, or all
> of them ?) and let libc do the buffering on file reading/writing ?

I quess *something* should be done. I was (and still is) a newbie to wine
source, so I solved this (wanted to be able to play wzebra ;-) out this way.
I needed only to change file.c and a few prototypes on smb.h. I wish somebody
(maybe you?) who knows more and has more time could take this job...

I think the main problem is (btw.. for most applications, there is no
problem..) that unix files are opened and closed for every, even small
ReadFile(). Doesn't it flush all buffers?

Hannu
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE90XtouA3ghgc3fUsRAo+jAKCnu4tNbeQkZFm5djiXdHr8WLFWJwCgoH+5
CYdCLFOZdWWDOirk4F+wbFo=
=Mxnd
-----END PGP SIGNATURE-----

ReadFile speedup

[Alexandre Julliard]

Hannu Kotipalo  writes:
> I think the main problem is (btw.. for most applications, there is no
> problem..) that unix files are opened and closed for every, even small
> ReadFile(). Doesn't it flush all buffers?

No, the problem is most likely that we have to do a round-trip to the
wine server for each read. Fixing that is not trivial at all, and
since it doesn't really impact most applications it's not a big
priority.