Re: [PATCH 1/2] d3drm: Move struct d3drm_texture to header for global access.

[Henri Verbeet]

On 20 March 2016 at 19:24, Aaryaman Vasishta  wrote:
> @@ -1038,12 +1029,11 @@ static const struct IDirect3DRMTexture3Vtbl d3drm_texture3_vtbl =
>      d3drm_texture3_SetValidationCallback,
>  };
>
> -HRESULT Direct3DRMTexture_create(REFIID riid, IUnknown **out)
> +HRESULT d3drm_texture_create(struct d3drm_texture **texture)
>  {
>      struct d3drm_texture *object;
> -
>
> HRESULT hr;
> -
>
> TRACE("riid %s, out %p.\n", debugstr_guid(riid), out);
> - TRACE("out %p.\n", texture);

You'll also want to fix the TRACE message here.

[PATCH 1/2] d3drm: Move struct d3drm_texture to header for global access.

[Aaryaman Vasishta]

Just sent a patch with the changes mentioned in both emails.

Thanks for the review!

Cheers,
Aaryaman

On Mon, Mar 21, 2016 at 6:59 PM, Henri Verbeet  wrote:
> On 20 March 2016 at 19:24, Aaryaman Vasishta 
> wrote:
> > @@ -1038,12 +1029,11 @@ static const struct IDirect3DRMTexture3Vtbl
>
> d3drm_texture3_vtbl =
> >  d3drm_texture3_SetValidationCallback,
> >
> > };
> >
> > -HRESULT Direct3DRMTexture_create(REFIID riid, IUnknown **out)
> > +HRESULT d3drm_texture_create(struct d3drm_texture **texture)
> >  {
> >      struct d3drm_texture *object;
> > -
> >
> > HRESULT hr;
> > -
> >
> > TRACE("riid %s, out %p.\n", debugstr_guid(riid), out);
> > - TRACE("out %p.\n", texture);
>
> You'll also want to fix the TRACE message here.