Re: [MSXML]xmlnode_get_nodeName Implementation

[Mike McCormack]

Hi Vijay,

Vijay Kiran Kamuju wrote:
> i think it would be better if we put bstr_from_xmlChar in msxml_private.h
> need directions how to implement domdoc_get_nodeName

I'll post a patch to move bstr_from_xmlChar and other utility functions 
somewhere else in the code later.
> please comment on the patch

For now the basics of msxml3 aren't really decided (eg. how to map 
xmlNodePtr to IXMLDOMNode, etc), and how to manage the relationship 
between nodes.  The way I'm managing node pointers will probably change 
again.

What I really need is more test cases, so if you have any msxml test 
cases lying around, then let me know.

Mike

[MSXML]xmlnode_get_nodeName Implementation

[Vijay Kiran Kamuju]

Hi Mike,

I am planning to write some tests for IXMLDOMNode.
I need your help on how to write tests in the wine test framework and
test on the windows framework.

Thanks,
Vijay

On 8/16/05, Mike McCormack  wrote:
> Hi Vijay,
>
> Vijay Kiran Kamuju wrote:
> > i think it would be better if we put bstr_from_xmlChar in msxml_private.h
> > need directions how to implement domdoc_get_nodeName
>
> I'll post a patch to move bstr_from_xmlChar and other utility functions
> somewhere else in the code later.
> > please comment on the patch
>
> For now the basics of msxml3 aren't really decided (eg. how to map
> xmlNodePtr to IXMLDOMNode, etc), and how to manage the relationship
> between nodes.  The way I'm managing node pointers will probably change
> again.
>
> What I really need is more test cases, so if you have any msxml test
> cases lying around, then let me know.
>
> Mike

[MSXML]xmlnode_get_nodeName Implementation

[Mike McCormack]

Vijay Kiran Kamuju wrote:
> I am planning to write some tests for IXMLDOMNode.
> I need your help on how to write tests in the wine test framework and
> test on the windows framework.

I started a simple test case in dlls/msxml3/tests/domdoc.c.  I modify it 
a little bit to get it to compile under MSVC 6.0.  I've attached the 
diff from the version that compiles on Windows.

Mike

[MSXML]xmlnode_get_nodeName Implementation

[Vijay Kiran Kamuju]

Hi Mike,

Do we have to register the IXMLDOMNode to the registry?
As you did in the test for domdoc.
I think we need to add all other basic interface's CLSID's to the registry?

Thanks,
Vijay

On 8/16/05, Mike McCormack  wrote:
> Vijay Kiran Kamuju wrote:
> > I am planning to write some tests for IXMLDOMNode.
> > I need your help on how to write tests in the wine test framework and
> > test on the windows framework.
>
> I started a simple test case in dlls/msxml3/tests/domdoc.c.  I modify it
> a little bit to get it to compile under MSVC 6.0.  I've attached the
> diff from the version that compiles on Windows.
>
> Mike

[MSXML]xmlnode_get_nodeName Implementation

[Mike McCormack]

Vijay Kiran Kamuju wrote:
> Do we have to register the IXMLDOMNode to the registry?
> As you did in the test for domdoc.
> I think we need to add all other basic interface's CLSID's to the registry?

IXMLDOMNode is an interface, which has an IID, not a CLSID.  We don't 
need to register interfaces for the moment, only CLSIDs.  The other 
CLSID we might want to register is CLSID_XMLDocument, but there's no 
implementation of that for the moment.  I have a stub in my tree, but I 
haven't submitted it as yet.

Interfaces only need to be registered if we want OLE automation (eg. 
IXMLDOMNode->Invoke()) to work, and I think they can be registered 
automatically using oleaut32.RegisterTypeLib().

Mike