Re: Extensive ScrollDC investigation

[Dmitry Timoshkov]

"Aric Stewart"  wrote:
> Reworking some parts of ScrollDC to properly mask and scroll the right 
> areas of the DC as well as generate the correct update regions.
> Extensive testing used to verify the behavior.

This test hangs forever for me under XP displaying a listbox with "ENTRY xx"
entries if winetest_debug != 0. Once I forcibly set winetest_debug = 0 the
test never produces test statistics (failed, skipped). The whole idea of
playing with winetest_debug and DRAW_CHECK inside of the drawing test looks
broken to me.

Extensive ScrollDC investigation

[Aric Stewart]

I do a scanf() inside of DRAW_CHECK so that you can look at the scroll 
results and hit enter in the console to go on.

If that is not good I can change or even remove the DRAW_CHECK but when 
i was comparing the results it was handy to be able to have the test pause.

-aric

Dmitry Timoshkov wrote:
> "Aric Stewart"  wrote:
> > Reworking some parts of ScrollDC to properly mask and scroll the 
> > right areas of the DC as well as generate the correct update regions.
> > Extensive testing used to verify the behavior.
>
> This test hangs forever for me under XP displaying a listbox with 
> "ENTRY xx"
> entries if winetest_debug != 0. Once I forcibly set winetest_debug = 0 
> the
> test never produces test statistics (failed, skipped). The whole idea of
> playing with winetest_debug and DRAW_CHECK inside of the drawing test 
> looks
> broken to me.

Extensive ScrollDC investigation

[Kuba Ober]

On Monday 30 April 2007, Aric Stewart wrote:
> I do a scanf() inside of DRAW_CHECK so that you can look at the scroll
> results and hit enter in the console to go on.
>
> If that is not good I can change or even remove the DRAW_CHECK but when
> i was comparing the results it was handy to be able to have the test pause.

Do the check programmatically - grab the bitmaps and do proper bit-by-bit 
comparisons.

The tests are meant to be automatic and run without supervision.

Cheers, Kuba

Extensive ScrollDC investigation

[Aric Stewart]

Yeah i thought about that but fonts and such may change causing a test 
to generate a false failure. Discussing with with Alexandre it appeared 
to me that just an eyeball check would be best.

All the delays and such are all behind winetest_debug checks so when run 
in an programmatic way they will not be triggered allowing the test to 
run without supervision.

-aric

Kuba Ober wrote:
> On Monday 30 April 2007, Aric Stewart wrote:
> > I do a scanf() inside of DRAW_CHECK so that you can look at the scroll
> > results and hit enter in the console to go on.
> >
> > If that is not good I can change or even remove the DRAW_CHECK but when
> > i was comparing the results it was handy to be able to have the test pause.
>
> Do the check programmatically - grab the bitmaps and do proper bit-by-bit 
> comparisons.
>
> The tests are meant to be automatic and run without supervision.
>
> Cheers, Kuba

Extensive ScrollDC investigation

[Jan Zerebecki]

On Mon, Apr 30, 2007 at 10:11:36AM -0500, Aric Stewart wrote:
> All the delays and such are all behind winetest_debug checks so when run 
> in an programmatic way they will not be triggered allowing the test to 
> run without supervision.

Wine tests should be automatic unless winetest_interactive. I
think winetest_debug is only for printing more debug messages.

Jan