Hi Andrew.
While reading your Patches, i stumble over deadbeef.
We use the value 0xdeadbeef almost everywhere in the tests to initialize a variable to an unusual value.
Using deadbeef as a variable name looks strange and make the code harder to read and understand.
Please change the name in your Patchset.
On 07/19/2010 11:01 AM, Detlef Riekenberg wrote:
Hi Andrew.
While reading your Patches, i stumble over deadbeef.
We use the value 0xdeadbeef almost everywhere in the tests to initialize a variable to an unusual value.
Using deadbeef as a variable name looks strange and make the code harder to read and understand.
Please change the name in your Patchset.
Sure, I can rename the "deadbeef" strings to "deadbeefA" to mirror "deadbeefW", if that's acceptable.
-
Andrew Nguyen -
Detlef Riekenberg