Hi Alex,
I think your VarBstrFromDec fails with my testcases, and you should not hardcode the decimal format seperator. And your patch fails my tests. Check my patchhttp://www.winehq.org/pipermail/wine-patches/2005-September/020777.htmlfor VarBstrFromDec(for my implementation and tests), my implementation is partial. You did a gr8 job implemeting the DECIMAL stuff in oleaut32. I have been sending and resending my patch since a month. I hope yours gets commited soon.
bye Vijay
Vijay Kiran Kamuju wrote:
Hi Alex,
I think your VarBstrFromDec fails with my testcases, and you should not hardcode the decimal format seperator. And your patch fails my tests. Check my patchhttp://www.winehq.org/pipermail/wine-patches/2005-September/020777.htmlfor VarBstrFromDec(for my implementation and tests), my implementation is partial. You did a gr8 job implemeting the DECIMAL stuff in oleaut32. I have been sending and resending my patch since a month. I hope yours gets commited soon.
bye Vijay
I guess the failing part is the one where the decimal separator is supposed to change between locales, but doesn't. My patch was based on the (mistaken) assumption that the VARIANT_MakeBstr() function would take care of the decimal separator for each locale. I will add your tests to my patch and resubmit with the necessary changes tomorrow.
As for sending the patch over and over in the month, I was sitting on mine because I tried to send it during three months and wasn't accepted. I assumed that it was because I failed to provide testcases.
Alex Villacís Lasso
Alex Villacís Lasso wrote: [..]
As for sending the patch over and over in the month, I was sitting on mine because I tried to send it during three months and wasn't accepted. I assumed that it was because I failed to provide testcases.
Maybe. But it is also too big. Try splitting it up: put VarDecMul, VarDecDiv and VarDecFromBstr into separate patches together with the tests. If i don't forget i will send you some test cases for VarDecMul too as i have started to implement that one too (handling of some corner cases was missing).
bye michael
-
Alex Villacís Lasso -
Michael Stefaniuc -
Vijay Kiran Kamuju