Re: mscms: quiet a noisy fixme (1/3)

[Detlef Riekenberg]

On Do, 2008-10-16 at 19:44 -0500, Austin English wrote:
> -
>    if (quietfixme == 0)
> -
>    {
> -
>        FIXME("unhandled bitmap format\n");

Such a FIXME has no useful information.
You should also dump the unhandled bitmap format in the FIXME
> -
>        quietfixme = 1;
> -
>        return TYPE_RGB_8;
> -
>    }

When you swap both lines above, ...
>  }
> - return 0;

... you should no longer need the "return 0" above.
> }

mscms: quiet a noisy fixme (1/3)

[Austin English]

On Fri, Oct 17, 2008 at 12:09 PM, Detlef Riekenberg  wrote:
> On Do, 2008-10-16 at 19:44 -0500, Austin English wrote:
> > -
> >    if (quietfixme == 0)
> > -
> >    {
> > -
> >        FIXME("unhandled bitmap format\n");
>
> Such a FIXME has no useful information.
> You should also dump the unhandled bitmap format in the FIXME

There's a trace above that does that, though the FIXME should as well.
> > -
> >        quietfixme = 1;
> > -
> >        return TYPE_RGB_8;
> > -
> >    }
>
> When you swap both lines above, ...
> >  }
> > - return 0;
>
> ... you should no longer need the "return 0" above.
> > }

Nope, still fails.