Re: winebrowser: Interpret the DDE data as CHAR or WCHAR just like the shell32 dde_connect helper sends it
On Friday 05 December 2008 14:05:08 Paul Chitescu wrote:
Shell32 sends either 8 bit or 16 bit strings in XTYP_EXECUTE depending on the highest bit of "operating system version" - ASCII based or Unicode based. When the data is used in winebrowser it must be interpreted the same.
The impression I get from reading MSDN is that the character set depends on whether the client called DdeInitializeA or DdeInitializeW, and it can be overridden too by setting iCodePage in the CONVCONTEXT structure.
-Hans
Hi!
The problem is not about the service name or other identifiers but rather the obscure data pushed by the DdeClientTransaction. DDE knows nothing about the format of this data as this is rather a convention between the client (shell32) and the server (winebrowser).
Paul Chitescu
On Friday 05 December 2008 15:49:52 Hans Leidekker wrote:
On Friday 05 December 2008 14:05:08 Paul Chitescu wrote:
Shell32 sends either 8 bit or 16 bit strings in XTYP_EXECUTE depending on the highest bit of "operating system version" - ASCII based or Unicode based. When the data is used in winebrowser it must be interpreted the same.
The impression I get from reading MSDN is that the character set depends on whether the client called DdeInitializeA or DdeInitializeW, and it can be overridden too by setting iCodePage in the CONVCONTEXT structure.
-Hans
On Friday 05 December 2008 15:17:47 Paul Chitescu wrote:
The problem is not about the service name or other identifiers but rather the obscure data pushed by the DdeClientTransaction. DDE knows nothing about the format of this data as this is rather a convention between the client (shell32) and the server (winebrowser).
But is it safe to assume that shell32 is the only client of winebrowser?
-Hans
On Friday 05 December 2008 16:33:04 Hans Leidekker wrote:
On Friday 05 December 2008 15:17:47 Paul Chitescu wrote:
The problem is not about the service name or other identifiers but rather the obscure data pushed by the DdeClientTransaction. DDE knows nothing about the format of this data as this is rather a convention between the client (shell32) and the server (winebrowser).
But is it safe to assume that shell32 is the only client of winebrowser?
-Hans
The few examples I've found for direct IE invocation pass a HDDEDATA handle created by DdeCreateStringHandle (a HSZ). Wine's implementation seems to simply get the data and length from the data and send it over DDE (in WDML_ClientQueueExecute). No idea if string type is preserved in Windows.
The fact winebrowser doesn't crash suggest no program is doing DdeClientTransaction directly ;-) although it may be possible that winebrowser just prints this warning message which my patch fixes:
Unabled to retrieve URL from string L"""
LOL!
We could easily guess if the data received by winebrowser has the wrong character size since normally the 1st character is a quote. However this doesn't look clean to me.
Paul
-
Hans Leidekker -
Paul Chitescu