Re: [bcrypt] add missing definitions

[Dmitry Timoshkov]

Vijay Kiran Kamuju  wrote:
> +#define MS_PRIMITIVE_PROVIDER                   L"Microsoft Primitive Provider"
> -
>
> +/* Algorithm Identifiers */
> +#define BCRYPT_RSA_ALGORITHM                    L"RSA"

This can't work properly in Wine.

[bcrypt] add missing definitions

[Vijay Kiran Kamuju]

Hmm... This is as per the mingw headers.

Then should I remove the definition of the Microsoft primitive provider .

Thanks,
Vijay

On Tue, Jan 14, 2014 at 11:13 AM, Dmitry Timoshkov  wrote:
> Vijay Kiran Kamuju  wrote:
> > +#define MS_PRIMITIVE_PROVIDER                   L"Microsoft Primitive Provider"
> > -
> >
> > +/* Algorithm Identifiers */
> > +#define BCRYPT_RSA_ALGORITHM                    L"RSA"
>
> This can't work properly in Wine.
>
> --
> Dmitry.

[bcrypt] add missing definitions

[Marcus Meissner]

Hi,

The L"string" notation is not going to work, Dmitry did not 
point out that specifically ;)

L"strings" generate 4 byte multichar strings, while Windows
expects 2 byte multichar strings.

You need something like
WCHAR foo[] = {'M','i','c'.... , 0 }; notation

Ciao, Marcus
On Tue, Jan 14, 2014 at 05:09:00PM +0100, Vijay Kiran Kamuju wrote:
> Hmm... This is as per the mingw headers.
>
> Then should I remove the definition of the Microsoft primitive provider .
>
> Thanks,
> Vijay
>
> On Tue, Jan 14, 2014 at 11:13 AM, Dmitry Timoshkov  wrote:
> > Vijay Kiran Kamuju  wrote:
> > > +#define MS_PRIMITIVE_PROVIDER                   L"Microsoft Primitive Provider"
> > > -
> > >
> > > +/* Algorithm Identifiers */
> > > +#define BCRYPT_RSA_ALGORITHM                    L"RSA"
> >
> > This can't work properly in Wine.
> >
> > --
> > Dmitry.

[bcrypt] add missing definitions

[Vijay Kiran Kamuju]

Thought the same, but I thought Dmitry was say about the provider name...

Will fix and send a new version, once I get home.

Thanks,
Vijay

On Tue, Jan 14, 2014 at 5:15 PM, Marcus Meissner  wrote:
> Hi,
>
> The L"string" notation is not going to work, Dmitry did not
> point out that specifically ;)
>
> L"strings" generate 4 byte multichar strings, while Windows
> expects 2 byte multichar strings.
>
> You need something like
> WCHAR foo[] = {'M','i','c'.... , 0 }; notation
>
> Ciao, Marcus
> On Tue, Jan 14, 2014 at 05:09:00PM +0100, Vijay Kiran Kamuju wrote:
> > Hmm... This is as per the mingw headers.
> >
> > Then should I remove the definition of the Microsoft primitive provider .
> >
> > Thanks,
> > Vijay
> >
> > On Tue, Jan 14, 2014 at 11:13 AM, Dmitry Timoshkov  wrote:
> > > Vijay Kiran Kamuju  wrote:
> > > > +#define MS_PRIMITIVE_PROVIDER                   L"Microsoft Primitive Provider"
> > > > -
> > > >
> > > > +/* Algorithm Identifiers */
> > > > +#define BCRYPT_RSA_ALGORITHM                    L"RSA"
> > >
> > > This can't work properly in Wine.
> > >
> > > --
> > > Dmitry.

[bcrypt] add missing definitions

[Vijay Kiran Kamuju]

Hi All,

I am confused now, as I can see few header files which have L"" strings in them.

eg:winnt.h, uxtheme.h, softpub.h, etc

command used:

grep L" *.h

Thanks,
Vijay

On Tue, Jan 14, 2014 at 4:47 PM, Vijay Kiran Kamuju  wrote:
> Thought the same, but I thought Dmitry was say about the provider name...
>
> Will fix and send a new version, once I get home.
>
> Thanks,
> Vijay
>
> On Tue, Jan 14, 2014 at 5:15 PM, Marcus Meissner  wrote:
> > Hi,
> >
> > The L"string" notation is not going to work, Dmitry did not
> > point out that specifically ;)
> >
> > L"strings" generate 4 byte multichar strings, while Windows
> > expects 2 byte multichar strings.
> >
> > You need something like
> > WCHAR foo[] = {'M','i','c'.... , 0 }; notation
> >
> > Ciao, Marcus
> > On Tue, Jan 14, 2014 at 05:09:00PM +0100, Vijay Kiran Kamuju wrote:
> > > Hmm... This is as per the mingw headers.
> > >
> > > Then should I remove the definition of the Microsoft primitive provider .
> > >
> > > Thanks,
> > > Vijay
> > >
> > > On Tue, Jan 14, 2014 at 11:13 AM, Dmitry Timoshkov  wrote:
> > > > Vijay Kiran Kamuju  wrote:
> > > > > +#define MS_PRIMITIVE_PROVIDER                   L"Microsoft Primitive Provider"
> > > > > -
> > > > >
> > > > > +/* Algorithm Identifiers */
> > > > > +#define BCRYPT_RSA_ALGORITHM                    L"RSA"
> > > >
> > > > This can't work properly in Wine.
> > > >
> > > > --
> > > > Dmitry.

[bcrypt] add missing definitions

[Henri Verbeet]

On 14 January 2014 20:13, Vijay Kiran Kamuju  wrote:
> Hi All,
>
> I am confused now, as I can see few header files which have L"" strings in them.
>
> eg:winnt.h, uxtheme.h, softpub.h, etc

Those are all behind some variant of "#if defined(_MSC_VER)". I.e.,
they'll only get used on MSVC.