Re: [PATCH 4/4] d3d9/tests: Add basic tests for vertex blending.

[Henri Verbeet]

On 2 July 2015 at 08:26, Józef Kucia  wrote:
> - static const float quad_upper_right[] =
> - {
> -
>    -1.0f, -1.0f, 0.0f, 0.0f, 0.0f, 0.0f,
> -
>    -1.0f,  1.0f, 0.0f, 0.0f, 0.0f, 0.0f,
> -
>     1.0f, -1.0f, 0.0f, 0.0f, 0.0f, 0.0f,
> -
>     1.0f,  1.0f, 0.0f, 0.0f, 0.0f, 0.0f,
> - },

I think it's slightly more readable to specify these as e.g.
    static const struct
    {
        struct vec3 position;
        struct vec3 blendweights;
    }
    quad_upper_right[] =
    {
        ...
    },
instead of an otherwise unstructured collection of floats. You can
also potentially fold these into the tests[] array.
> - static const struct {
> -
>    const float *vertex_data;
> -
>    const POINT *quad_points;
> -
>    const POINT *empty_points;
> - }
> - tests[] =

Position of the upper brace.