Re: [v7 1/5] server: Named pipe query SD from pipe object

[Jacek Caban]

Hi Jonathan,

Your tests still don't really show intended behaviour. Your calls that
set security descriptor use new SD that has the same tested values as
before the call, then what's the point in setting it? Anyway, I cleaned
it up and changed a bit to see how it's really supposed to work. See the
attachment.

It looks like client and served should indeed share security descriptor,
but pipe object should not, so that part is wrong.

Thanks,
Jacek

[v7 1/5] server: Named pipe query SD from pipe object

[Jonathan Doron]

Hi Jackek,

I went over your patch but I believe it might have few issues that i wanted
to raise before we change anything
1. For some reason when you are doing the "ok" test after CreateNamedPipe
you do against != NULL should != INVALID_HANDLE_VALUE
    this is critical... since the 2nd server might have failed with
OBJECT_NAME_ALREADY_EXISTS
2. When you create the 2nd server instance against the "ok" check is
against NULL but not only that, you check against "server" and not "server2"

The reason I'm raising these issues is because from my understanding of
Windows, there can be only 1 instance for a given named pipe instance,
Please see that once you change these things, my logic remains correct...
and that simply server2 was never created and got INVALID_HANDLE_VALUE
with a should be GLE of 231 aka ERROR_PIPE_BUSY.

Please let me know how it goes so we will know how to continue.

Thanks and I hope you have a great weekend,
-- Jon.

On Wed, Sep 27, 2017 at 6:33 PM, Jacek Caban  wrote:
> Hi Jonathan,
>
> Your tests still don't really show intended behaviour. Your calls that
> set security descriptor use new SD that has the same tested values as
> before the call, then what's the point in setting it? Anyway, I cleaned
> it up and changed a bit to see how it's really supposed to work. See the
> attachment.
>
> It looks like client and served should indeed share security descriptor,
> but pipe object should not, so that part is wrong.
>
> Thanks,
> Jacek

[v7 1/5] server: Named pipe query SD from pipe object

[Jacek Caban]

Hi Jonathan,

On 29.09.2017 14:35, Jonathan Doron wrote:
> Hi Jackek,
>
> I went over your patch but I believe it might have few issues that i
> wanted to raise before we change anything
> - For some reason when you are doing the "ok" test after
>
> CreateNamedPipe you do against != NULL should != INVALID_HANDLE_VALUE
>     this is critical... since the 2nd server might have failed with
> OBJECT_NAME_ALREADY_EXISTS
> 2. When you create the 2nd server instance against the "ok" check is
> against NULL but not only that, you check against "server" and not
> "server2"

Good catch, thanks.
> The reason I'm raising these issues is because from my understanding
> of Windows, there can be only 1 instance for a given named pipe instance,

There may be as many instances as you specify in CreateNamedPipe call.

I fixed tests to handle that properly (see attachment). And, indeed, it
looks like SD is shared between all pipe instances.

Thanks,
Jacek