Re: Patch for Wine-20030115 heap allocation on Solaris 8 x86

[John Wehle]

> On Fri, Jan 17, 2003 at 01:52:08PM -0500, John Wehle wrote:
> > Currently wine exits after complaining about an invalid heap during
> > startup on Solaris 8 x86.  What happens is mmap is returning an address
> > above 0xc0000000 which HEAP_InitSubHeap passes to NtAllocateVirtualMemory
> > who rejects it.  Perhaps someone familiar with the code can suggest
> > a better solution or explain why the ADDRESS_SPACE_LIMIT check is there.
> Correct me if I'm wrong, but AFAICS this is even the third time that you
> submit this.

Yep.
> Don't you think that it would have been time to ask Alexandre
> what the hell he's been thinking about constantly rejecting it ? ;-)

Didn't know it had been rejected.

I'm really not up on how wine development is done.  In general I'm suppose
to email [e-mail] if I don't receive an ACK / NACK regarding a
patch?

-- John
-------------------------------------------------------------------------
|   Feith Systems  |   Voice: 1-215-646-8000  |  Email: [e-mail]  |
|    John Wehle    |     Fax: [phone]  |                         |
-------------------------------------------------------------------------

Patch for Wine-20030115 heap allocation on Solaris 8 x86

[Dan Kegel]

John Wehle wrote:
> > Don't you think that it would have been time to ask Alexandre
> > what the hell he's been thinking about constantly rejecting it ? ;-)
>
> Didn't know it had been rejected.
>
> I'm really not up on how wine development is done.  In general I'm suppose
> to email [e-mail] if I don't receive an ACK / NACK regarding a
> patch?

I think it's more like:

If you get any feedback about a proposed patch on the mailing
list, you need to deal with the feedback one way or another
before the patch will be applied.

That allows Alexandre to just snoop the mailing list to
get a feel for what patches pass muster.
- Dan