Re: [PATCH] advapi32: Add some tests for StartTrace(). (v2)

[Austin English]

On Jul 4, 2016 1:25 AM, "Zebediah Figura"  wrote:
> dlls/advapi32/tests/eventlog.c | 139

+++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 139 insertions(+)
>
> diff --git a/dlls/advapi32/tests/eventlog.c

b/dlls/advapi32/tests/eventlog.c
> index 3ca59c3..5163537 100644
> --- a/dlls/advapi32/tests/eventlog.c
> +++ b/dlls/advapi32/tests/eventlog.c
> @@ -20,12 +20,15 @@
>
> #include <stdarg.h>
>
> +#include "initguid.h"
>  #include "windef.h"
>  #include "winbase.h"
>  #include "winerror.h"
>  #include "winnt.h"
>  #include "winreg.h"
>  #include "sddl.h"
> +#include "wmistr.h"
> +#include "evntrace.h"
>
> #include "wine/test.h"
>
> @@ -1142,6 +1145,141 @@ static void cleanup_eventlog(void)
>      ok(bret, "Expected MoveFileEx to succeed: %d\n", GetLastError());
>  }
>
> +static void test_trace(void)
> +{
> - const char sessionname[] = "Wine";
> - const char filepath[] = "wine.etl";
> - const LONG lnoffset = ((sizeof(EVENT_TRACE_PROPERTIES) >> 3) + 1) <<

3; //pad to 8 bytes
> - const LONG lfnoffset = (((lnoffset + sizeof(sessionname)) >> 3) + 1)

<< 3; //pad to 8 bytes

Please avoid C++ style comments,  use /* this instead */