I'm never going to get this code in, am i?
On Tue, 2015-02-17 at 11:00 +1100, Andrew Cook wrote:
Forgot a semicolon (i actually tested this one, it compiles)
dlls/kernel32/tests/Makefile.in | 1 + dlls/kernel32/tests/job.c | 393 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 394 insertions(+) create mode 100644 dlls/kernel32/tests/job.c
On 17.02.2015 3:55, Andrew Cook wrote:
I'm never going to get this code in, am i?
Why not? First make sure it passes testbot, and that you addressed all comments from last time to submitted this. If it's still ignored ask on list/irc. By the way, why do you need a separate file for that? Seems to me it would nicely fit into process.c.
On Tue, 2015-02-17 at 11:00 +1100, Andrew Cook wrote:
Forgot a semicolon (i actually tested this one, it compiles)
dlls/kernel32/tests/Makefile.in | 1 + dlls/kernel32/tests/job.c | 393 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 394 insertions(+) create mode 100644 dlls/kernel32/tests/job.c
process.c already uses child processes and I'd rather not multiplex them. Aside from that the only issue with the patch is a missing semicolon, which wasn't committed so format-patch ignored it.
Doubting it'll be merged since i tried to add these two years ago, and my patches were ignored.
This is a rewrite, since the original patch was a mess.
On Tue, 2015-02-17 at 08:07 +0300, Nikolay Sivov wrote:
On 17.02.2015 3:55, Andrew Cook wrote:
I'm never going to get this code in, am i?
Why not? First make sure it passes testbot, and that you addressed all comments from last time to submitted this. If it's still ignored ask on list/irc. By the way, why do you need a separate file for that? Seems to me it would nicely fit into process.c.
On Tue, 2015-02-17 at 11:00 +1100, Andrew Cook wrote:
Forgot a semicolon (i actually tested this one, it compiles)
dlls/kernel32/tests/Makefile.in | 1 + dlls/kernel32/tests/job.c | 393 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 394 insertions(+) create mode 100644 dlls/kernel32/tests/job.c
Andrew Cook ariscop@gmail.com writes:
process.c already uses child processes and I'd rather not multiplex them. Aside from that the only issue with the patch is a missing semicolon, which wasn't committed so format-patch ignored it.
Doubting it'll be merged since i tried to add these two years ago, and my patches were ignored.
You could start by addressing the comments you did get, before asking for more. For instance, like Nikolay said, and like I already said last time around, this doesn't need a new file.
-
Alexandre Julliard -
Andrew Cook -
Nikolay Sivov