Re: Set TZ environment variable when not set

[Alexandre Julliard]

Uwe Bonnes  writes:
> Changelog:
>    memory/environ.c: build_environment
>    Set the TZ value to GMT0, if TZ is not set
>
> Synplify.exe from the Quicklogic FPGA suite refused to work with the demo
> license. Setting TZ to any value made it work.

You should set it in your environment then, this doesn't belong in Wine.

Set TZ environment variable when not set

[David Laight]

On Wed, Apr 16, 2003 at 02:56:22PM -0700, Alexandre Julliard wrote:
> Uwe Bonnes  writes:
> > Changelog:
> >    memory/environ.c: build_environment
> >    Set the TZ value to GMT0, if TZ is not set
> >
> > Synplify.exe from the Quicklogic FPGA suite refused to work with the demo
> > license. Setting TZ to any value made it work.
>
> You should set it in your environment then, this doesn't belong in Wine.

Absolutely, it isn't necessary on some unix variants (eg NetBSD) and
it can't actually hold the reqiured information.
Setting it will override the default value for the user.

David

Set TZ environment variable when not set

[Duane Clark]

David Laight wrote:
> Absolutely, it isn't necessary on some unix variants (eg NetBSD) and
> it can't actually hold the reqiured information.
> Setting it will override the default value for the user.

In Uwe's code, it is only set if it does not already exist. He does not 
override anything.

Set TZ environment variable when not set

[Uwe Bonnes]

> > > > > "David" == David Laight  writes:

David> On Wed, Apr 16, 2003 at 02:56:22PM -0700, Alexandre Julliard
    David> wrote:
    >> Uwe Bonnes  writes:
    >> 
    >> > Changelog: > memory/environ.c: build_environment > Set the TZ value
    >> to GMT0, if TZ is not set
                         ^^^^^^^

>> > 
    >> > Synplify.exe from the Quicklogic FPGA suite refused to work with
    >> the demo > license. Setting TZ to any value made it work.
    >> 
    >> You should set it in your environment then, this doesn't belong in
    >> Wine.

David> Absolutely, it isn't necessary on some unix variants (eg NetBSD)
    David> and it can't actually hold the reqiured information.  Setting it
    David> will override the default value for the user.

David,

did you look at the patch or the changelog? :-(
My proposed patch only sets TZ to a default value when TZ is _not_ set

Actually I have been hunting the synplify behaviour for years on and off.
Having a way to run synplify.exe with the demo license will probably help
some users of Quicklogic/Lattice/... EDA tools.

Bye

Set TZ environment variable when not set

[David Laight]

> David> Absolutely, it isn't necessary on some unix variants (eg NetBSD)
> David> and it can't actually hold the reqiured information.  Setting it
> David> will override the default value for the user.
>
> David,
>
> did you look at the patch or the changelog? :-(
> My proposed patch only sets TZ to a default value when TZ is _not_ set
> From my system:

$ date
Thu Apr 17 09:33:50 BST 2003
$ echo $TZ

$ TZ=GMT0 date
Thu Apr 17 08:34:02 GMT 2003
$ TZ=xyz-167 date
Thu Apr 24 07:39:40 xyz 2003
$

If TZ is set, then its value is used.  If it isn't set then the timezone
information comes from elsewhere - probably the LOCALE.

David