Hello friends,
thank you for working on this. I think you will improve the chances for your patches to be accepted if you give them individually meaningful names, like
"notepad: Don't use reserved MSVC keyword."
for patch #2.
Actually, I followed the tip I read into the wiki of WINE in "Patch submission guidelines", so I tried to imitate the style of other patches for WINE and for this reason I used an identical title with a progressive number as subject. If something different is prefered, no problem, I will follow your suggestion and I will use a more focused title.
Also, like Jerome said, we may have a problem if different people commited these changes to ReactOS. I'm no expert on this, but as I understand, Wine needs the patch to be credited to the author who actually wrote the code.
Well, ReactOS notepad had been imported from WINE long time ago and various people did some changes on it and I'm included in them since, in this specific case, the status bar implementation had been almost rewritten by me. I'm not an expert too, but since it is distribuited under the same license of WINE, with same coding restrictions and all people who sent patches have agreed to the same GPL as well, my intuition would say that there is no problem on this... because the owner who can providing this code to you is the ReactOS project itself. That's just my opinion of course... I will wait for your suggestions/orders... ;-)
Sincerely,
Carlo Bramini.
Hi,
Wine has a policy of not accepting code from ReactOS due to the legal uncertainty introduced by questionable reverse engineering techniques used by some ReactOS devs, and I am not aware of a change in that policy.
Stefan
On Sun, May 6, 2012 at 3:16 PM, Stefan Dösinger stefandoesinger@gmx.atwrote:
Hi,
Wine has a policy of not accepting code from ReactOS due to the legal uncertainty introduced by questionable reverse engineering techniques used by some ReactOS devs, and I am not aware of a change in that policy.
Stefan
I don't see how that would apply to notepad though.
J. Leclanche
On Sun, May 6, 2012 at 7:49 AM, carlo.bramix@libero.it carlo.bramix@libero.it wrote:
thank you for working on this. I think you will improve the chances for your patches to be accepted if you give them individually meaningful names, like ...
Actually, I followed the tip I read into the wiki of WINE in "Patch submission guidelines", so I tried to imitate the style of other patches for WINE and for this reason I used an identical title with a progressive number as subject. ...
What that instruction is meant to say is that patches that are part of a series (meant to go one after the other) should be numbered sequentially, but still have a descriptive title. So, something like:
[PATCH 1/3] notepad.exe: Fix formatting of resource file. [PATCH 2/3] notepad.exe: Do not use the MSVC reserved keyword "class". [PATCH 3/3] notepad.exe: Unify find and replace functionality.
Note that these examples are just from scanning your descriptions, there may be better patch titles that you can use.
... Well, ReactOS notepad had been imported from WINE long time ago and various people did some changes on it and I'm included in them since, in this specific case, the status bar implementation had been almost rewritten by me. ...
The issue is whether the appropriate guidelines were followed (http://wiki.winehq.org/CleanRoomGuidelines). One issue is that Wine does not allow people that have ever viewed Microsoft source code to contribute to Wine, but there are other issues. You'll have to talk to Alexandre and see how he feels about this specific issue, but if you've followed all of the guidelines and contribute only your own changes then he might be ok with your contribution.
Erich Hoover ehoover@mines.edu
-
carlo.bramix＠libero.it -
Erich E. Hoover -
Jerome Leclanche -
Stefan Dösinger