Jon Griffiths jon_p_griffiths@yahoo.com writes:
+dlls/user/listbox.c Draw background of the empty selected item in empty lists Dont draw a focus rect if we do not have the focus Dont select items on key up/down in multi-select lists
This is causing a test failure:
listbox.c:134: Test failed: style 0x8, step step, field selected: expected 2, got 1 listbox.c:134: Test succeeded inside todo block: style 0x8, step step, field selcount: expected 1, got 1
(the second one is a good thing of course...)
On Friday 24 September 2004 03:13, Alexandre Julliard wrote:
+dlls/user/listbox.c Draw background of the empty selected item in empty lists Dont draw a focus rect if we do not have the focus Dont select items on key up/down in multi-select lists
This is causing a test failure:
listbox.c:134: Test failed: style 0x8, step step, field selected: expected 2, got 1
Wow, is this what I think it is? I mean, did our test harness show it's protential here to detect regressions at check-in time?
Does that happen often? Should Wine developers start running the tests before submitting a patch?
-Hans
Does that happen often? Should Wine developers start running the tests before submitting a patch?
Absolutely, my bad. I didn't actually realise they were any listbox tests!
Updated patch coming.
Jon
===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live
jon_p_griffiths@yahoo.com
__________________________________ Do you Yahoo!? New and Improved Yahoo! Mail - Send 10MB messages! http://promotions.yahoo.com/new_mail
Hans Leidekker hans@it.vu.nl writes:
Wow, is this what I think it is? I mean, did our test harness show it's protential here to detect regressions at check-in time?
Does that happen often? Should Wine developers start running the tests before submitting a patch?
Yes it happens regularly, maybe once or twice a month. And yes, it would be a good idea for other developers to run the tests too.
Alexandre Julliard wrote:
Yes it happens regularly, maybe once or twice a month. And yes, it would be a good idea for other developers to run the tests too.
Thing is, they don't run for me. On a clean CVS checkout after compile, I get:
wine$ make test make[1]: Entering directory `/home/sun/sources/wine/wine/dlls' make[2]: Entering directory `/home/sun/sources/wine/wine/dlls/advapi32' make[3]: Entering directory `/home/sun/sources/wine/wine/dlls/advapi32/tests' ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so crypt.c && touch crypt.ok Xlib: extension "XFree86-DRI" missing on display ":0.0". /home/sun/.wine updated successfully. fixme:crypt:CRYPT_VerifyImage (rsabase.dll, 0x40380ef8): not verifying image fixme:crypt:CRYPT_VerifyImage (rsabase.dll, 0x40380ef8): not verifying image fixme:crypt:CRYPT_VerifyImage (rsabase.dll, 0x40380ef8): not verifying image fixme:crypt:CRYPT_VerifyImage (rsabase.dll, 0x40380ef8): not verifying image fixme:crypt:CRYPT_VerifyImage (rsabase.dll, 0x40380ef8): not verifying image fixme:crypt:CRYPT_VerifyImage (rsabase.dll, 0x40380f18): not verifying image crypt.c:110: Test failed: 122 fixme:crypt:CRYPT_VerifyImage (rsabase.dll, 0x40380f18): not verifying image crypt.c:117: Test failed: 122 fixme:crypt:CRYPT_VerifyImage (rsabase.dll, 0x40380f18): not verifying image fixme:crypt:CRYPT_VerifyImage (rsabase.dll, 0x40380f18): not verifying image make[3]: *** [crypt.ok] Error 2 make[3]: Leaving directory `/home/sun/sources/wine/wine/dlls/advapi32/tests' make[2]: *** [tests/__test__] Error 2 make[2]: Leaving directory `/home/sun/sources/wine/wine/dlls/advapi32' make[1]: *** [advapi32/__test__] Error 2 make[1]: Leaving directory `/home/sun/sources/wine/wine/dlls' make: *** [dlls/__test__] Error 2
Since I know these same tests pass on Alexandre's machine, I can only assume there is something missing in my setup. However, as I don't know what, I simply let it go and do my best without running the tests.
Shachar
On Sun, Sep 26, 2004 at 05:07:41PM +0200, Shachar Shemesh wrote:
Alexandre Julliard wrote:
Yes it happens regularly, maybe once or twice a month. And yes, it would be a good idea for other developers to run the tests too.
Thing is, they don't run for me. On a clean CVS checkout after compile, I get:
I get the same advapi errors on a FC2 and a RHEL3 box, both up2date. That's why i normaly run a make -k test. Other tests failing for me are the dsound and wave tests but i blame for that the i810 chip. On the FC2 box (nvidia driver) the screen resizing fails too leaving the desktop in an unusable 640x480 size. That tests work on the RHEL3 laptop (ati graphics card), but on both i have to kill gnome-panel afterwards because it goes into a loop eating 100% of the CPU.
wine$ make test make[1]: Entering directory `/home/sun/sources/wine/wine/dlls' make[2]: Entering directory `/home/sun/sources/wine/wine/dlls/advapi32' make[3]: Entering directory `/home/sun/sources/wine/wine/dlls/advapi32/tests' ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so crypt.c && touch crypt.ok Xlib: extension "XFree86-DRI" missing on display ":0.0". /home/sun/.wine updated successfully. fixme:crypt:CRYPT_VerifyImage (rsabase.dll, 0x40380ef8): not verifying image
Since I know these same tests pass on Alexandre's machine, I can only assume there is something missing in my setup. However, as I don't know what, I simply let it go and do my best without running the tests.
That's my assumption too. But i'm running the tests at least in the dll i modified. Or i do a make -k test before and after the modifications and diff the output.
bye michael
Alexandre Julliard wrote:
Yes it happens regularly, maybe once or twice a month. And yes, it would be a good idea for other developers to run the tests too.
Thing is, they don't run for me. On a clean CVS checkout after compile, I get:
wine$ make test make[1]: Entering directory `/home/sun/sources/wine/wine/dlls' make[2]: Entering directory `/home/sun/sources/wine/wine/dlls/advapi32' make[3]: Entering directory `/home/sun/sources/wine/wine/dlls/advapi32/tests' ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so crypt.c && touch crypt.ok Xlib: extension "XFree86-DRI" missing on display ":0.0". /home/sun/.wine updated successfully. fixme:crypt:CRYPT_VerifyImage (rsabase.dll, 0x40380ef8): not verifying image fixme:crypt:CRYPT_VerifyImage (rsabase.dll, 0x40380ef8): not verifying image fixme:crypt:CRYPT_VerifyImage (rsabase.dll, 0x40380ef8): not verifying image fixme:crypt:CRYPT_VerifyImage (rsabase.dll, 0x40380ef8): not verifying image fixme:crypt:CRYPT_VerifyImage (rsabase.dll, 0x40380ef8): not verifying image fixme:crypt:CRYPT_VerifyImage (rsabase.dll, 0x40380f18): not verifying image crypt.c:110: Test failed: 122 fixme:crypt:CRYPT_VerifyImage (rsabase.dll, 0x40380f18): not verifying image crypt.c:117: Test failed: 122 fixme:crypt:CRYPT_VerifyImage (rsabase.dll, 0x40380f18): not verifying image fixme:crypt:CRYPT_VerifyImage (rsabase.dll, 0x40380f18): not verifying image make[3]: *** [crypt.ok] Error 2 make[3]: Leaving directory `/home/sun/sources/wine/wine/dlls/advapi32/tests' make[2]: *** [tests/__test__] Error 2 make[2]: Leaving directory `/home/sun/sources/wine/wine/dlls/advapi32' make[1]: *** [advapi32/__test__] Error 2 make[1]: Leaving directory `/home/sun/sources/wine/wine/dlls' make: *** [dlls/__test__] Error 2
Since I know these same tests pass on Alexandre's machine, I can only assume there is something missing in my setup. However, as I don't know what, I simply let it go and do my best without running the tests.
Shachar
-
Alexandre Julliard -
Hans Leidekker -
Jon Griffiths -
Michael Stefaniuc -
Shachar Shemesh