Re: [01/12] shell32/tests: The expectedArgs parameter of the DDE tests is an argument count, not a boolean.
Hi,
While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19403
Your paranoid android.
=== wxppro (32 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4
=== w2003std (32 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4
=== wvistau64 (32 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4
=== w2008s64 (32 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4
=== w7u (32 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4
=== w7pro64 (32 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4
=== w8 (32 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4
=== w864 (32 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4
=== w1064 (32 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2299: Test failed: ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde")]', got '[open("C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde")]' shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde") failed: rc=29 err=2
=== wvistau64 (64 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4
=== w2008s64 (64 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4
=== w7pro64 (64 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4
=== w864 (64 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4
=== w1064 (64 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt91AC.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt91AC.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt91AC.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt91AC.tmp\test file.sde") failed: rc=29 err=2
On Mon, 4 Jan 2016, Marvin wrote: [...]
=== w1064 (32 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2299: Test failed: ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde")]', got '[open("C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde")]' shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde") failed: rc=29 err=2
It turns out that on all platforms the failures happen in the DDE tests which I have not touched in my patches. I looked into those but I have no idea what's wrong with them.
Hans, Misha, you have worked on the DDE tests. Do you know what's wrong? If I trust the GetLastError() code (not sure I should), it would seem to be 'file not found problem' issue. But why only on Windows 10 and which file?
Hi Francois,
I'm very sorry, but I haven't worked on Wine in several years and I am not sure what is wrong :( . I hope that all is well!
Misha ________________________________________ From: Francois Gouget fgouget@codeweavers.com Sent: Wednesday, January 6, 2016 3:07 AM To: wine-devel@winehq.org Cc: Hans Leidekker; Koshelev, Misha Vladislavovich Subject: Re: [01/12] shell32/tests: The expectedArgs parameter of the DDE tests is an argument count, not a boolean.
On Mon, 4 Jan 2016, Marvin wrote: [...]
=== w1064 (32 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2299: Test failed: ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde")]', got '[open("C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde")]' shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde") failed: rc=29 err=2
It turns out that on all platforms the failures happen in the DDE tests which I have not touched in my patches. I looked into those but I have no idea what's wrong with them.
Hans, Misha, you have worked on the DDE tests. Do you know what's wrong? If I trust the GetLastError() code (not sure I should), it would seem to be 'file not found problem' issue. But why only on Windows 10 and which file?
-- Francois Gouget fgouget@codeweavers.com
On Wed, 6 Jan 2016, Francois Gouget wrote:
On Mon, 4 Jan 2016, Marvin wrote: [...]
=== w1064 (32 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4
The patch was still wrong: the above line was a new failure. I'll resubmit.
-
Francois Gouget -
Koshelev, Misha Vladislavovich -
Marvin