These fail on Windows 10 1607+ with nonsensical error codes.
Signed-off-by: Zebediah Figura z.figura12@gmail.com --- dlls/explorerframe/tests/nstc.c | 42 +++++++++------------------------ 1 file changed, 11 insertions(+), 31 deletions(-)
diff --git a/dlls/explorerframe/tests/nstc.c b/dlls/explorerframe/tests/nstc.c index 44bdf317f2d..a48e3affefe 100644 --- a/dlls/explorerframe/tests/nstc.c +++ b/dlls/explorerframe/tests/nstc.c @@ -885,7 +885,7 @@ static void test_basics(void) ok(hr == S_OK || broken(hr == E_FAIL), "Got 0x%08x\n", hr); if(hr == S_OK) { - static const NSTCSTYLE styles_setable[] = + static const NSTCSTYLE styles[] = { NSTCS_HASEXPANDOS,NSTCS_HASLINES,NSTCS_SINGLECLICKEXPAND, NSTCS_FULLROWSELECT,NSTCS_HORIZONTALSCROLL, NSTCS_ROOTHASEXPANDO,NSTCS_SHOWSELECTIONALWAYS,NSTCS_NOINFOTIP, @@ -894,11 +894,6 @@ static void test_basics(void) NSTCS_TABSTOP,NSTCS_FAVORITESMODE,NSTCS_EMPTYTEXT,NSTCS_CHECKBOXES, NSTCS_ALLOWJUNCTIONS,NSTCS_SHOWTABSBUTTON,NSTCS_SHOWDELETEBUTTON, NSTCS_SHOWREFRESHBUTTON, 0}; - static const NSTCSTYLE styles_nonsetable[] = - { NSTCS_SPRINGEXPAND, NSTCS_RICHTOOLTIP, NSTCS_AUTOHSCROLL, - NSTCS_FADEINOUTEXPANDOS, - NSTCS_PARTIALCHECKBOXES, NSTCS_EXCLUSIONCHECKBOXES, - NSTCS_DIMMEDCHECKBOXES, NSTCS_NOINDENTCHECKS,0};
/* Set/GetControlStyle */ style = style2 = 0xdeadbeef; @@ -909,22 +904,12 @@ static void test_basics(void) hr = INameSpaceTreeControl2_SetControlStyle(pnstc2, 0, 0xFFFFFFF); ok(hr == S_OK, "Got 0x%08x\n", hr);
- hr = INameSpaceTreeControl2_SetControlStyle(pnstc2, 0xFFFFFFFF, 0); - ok(hr == E_FAIL, "Got 0x%08x\n", hr); - hr = INameSpaceTreeControl2_SetControlStyle(pnstc2, 0xFFFFFFFF, 0xFFFFFFFF); - ok(hr == E_FAIL, "Got 0x%08x\n", hr); - tmp = 0; - for(i = 0; styles_setable[i] != 0; i++) - { - hr = INameSpaceTreeControl2_SetControlStyle(pnstc2, styles_setable[i], styles_setable[i]); - ok(hr == S_OK, "Got 0x%08x (%x)\n", hr, styles_setable[i]); - if(SUCCEEDED(hr)) tmp |= styles_setable[i]; - } - for(i = 0; styles_nonsetable[i] != 0; i++) + for(i = 0; styles[i] != 0; i++) { - hr = INameSpaceTreeControl2_SetControlStyle(pnstc2, styles_nonsetable[i], styles_nonsetable[i]); - ok(hr == E_FAIL, "Got 0x%08x (%x)\n", hr, styles_nonsetable[i]); + hr = INameSpaceTreeControl2_SetControlStyle(pnstc2, styles[i], styles[i]); + ok(hr == S_OK, "Got 0x%08x (%x)\n", hr, styles[i]); + if(SUCCEEDED(hr)) tmp |= styles[i]; }
hr = INameSpaceTreeControl2_GetControlStyle(pnstc2, 0xFFFFFFFF, &style); @@ -933,23 +918,18 @@ static void test_basics(void) if(SUCCEEDED(hr)) { DWORD tmp2; - for(i = 0; styles_setable[i] != 0; i++) + for(i = 0; styles[i] != 0; i++) { - hr = INameSpaceTreeControl2_GetControlStyle(pnstc2, styles_setable[i], &tmp2); + hr = INameSpaceTreeControl2_GetControlStyle(pnstc2, styles[i], &tmp2); ok(hr == S_OK, "Got 0x%08x\n", hr); - ok(tmp2 == (style & styles_setable[i]), "Got %x\n", tmp2); + ok(tmp2 == (style & styles[i]), "Got %x\n", tmp2); } }
- for(i = 0; styles_setable[i] != 0; i++) - { - hr = INameSpaceTreeControl2_SetControlStyle(pnstc2, styles_setable[i], 0); - ok(hr == S_OK, "Got 0x%08x (%x)\n", hr, styles_setable[i]); - } - for(i = 0; styles_nonsetable[i] != 0; i++) + for(i = 0; styles[i] != 0; i++) { - hr = INameSpaceTreeControl2_SetControlStyle(pnstc2, styles_nonsetable[i], 0); - ok(hr == E_FAIL, "Got 0x%08x (%x)\n", hr, styles_nonsetable[i]); + hr = INameSpaceTreeControl2_SetControlStyle(pnstc2, styles[i], 0); + ok(hr == S_OK, "Got 0x%08x (%x)\n", hr, styles[i]); } hr = INameSpaceTreeControl2_GetControlStyle(pnstc2, 0xFFFFFFFF, &style); ok(hr == S_OK, "Got 0x%08x\n", hr);
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=63241
Your paranoid android.
=== w1064v1507 (32 bit report) ===
explorerframe: nstc.c:2098: Test failed: Got event 17, count 1 nstc.c:2137: Test failed: Got event 17, count 1
=== w1064v1809_2scr (32 bit report) ===
explorerframe: nstc.c:2087: Test failed: Got event 17, count 1
=== w1064v1809_he (32 bit report) ===
explorerframe: nstc.c:1491: Test failed: Got 0x00000000 nstc.c:1493: Test failed: Got 0x80004005 nstc.c:1522: Test failed: Got 0x80004005 nstc.c:1644: Test failed: Got 0x00000001 18d4:nstc: unhandled exception c0000005 at 00406701
=== w1064v1809_zh_CN (32 bit report) ===
explorerframe: nstc.c:1913: Test failed: Got event 7, count 0 nstc.c:1915: Test failed: Got event 4, count 0 nstc.c:1922: Test failed: Got event 6, count 1 nstc.c:1928: Test failed: Got event 4, count 0 nstc.c:1929: Test failed: Got event 7, count 1 nstc.c:1929: Test failed: Got event 12, count 9
=== w1064v1809 (64 bit report) ===
explorerframe: nstc.c:2137: Test failed: Got event 17, count 10
-
Marvin -
Zebediah Figura