-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi,
You still have a few formatting issues in this patch, I've quoted the ones I found below.
I ran the test on my Windows boxes and it passed on the following devices:
Windows 7 x86_64, Radeon HD 5770 Windows 7 x86_64, Radeon X1600 Windows 7 x32, Nvidia GeForce 9600 Windows Vista x32, Nvidia GeForce 7400
It did not pass on my very ancient Windows XP x32 laptop with a Radeon 9000 Mobility. It fails there the same way as on the testbot - the card claims to support YUY2 and YV12, but the StretchRect call fails with D3DERR_INVALIDCALL. Do you have any idea why that might happen? If not maybe the best solution is to accept the error with broken() and skip the rest of the test.
There's IDirect3D9::CheckDeviceFormatConversion, but according to msdn it only tests backbuffer and adapter format compatibility. That's not the way we implement it, but I don't think we have tests to find out how it's really supposed to behave.
Fwiw none of the above machines claims I420 support. There are plenty of other odd formats though.
Am 2014-02-12 21:05, schrieb Martin Storsjo:
Use 8 space indentation vs the first line of the if and put the && into the next line.
Same as above.
Curly bracket placement.
Same.
8 space indent on line contiuation as in if conditions.
On Thu, 13 Feb 2014, Stefan Dösinger wrote:
You still have a few formatting issues in this patch, I've quoted the ones I found below.
The quotes seem to be missing, but I think I found the places you referred to. I'll resend the full set now.
// Martin
-
Martin Storsjö -
Stefan Dösinger