Hi Juan,
With this patch, the bottom of file dialogs are cut off such that the file type dropdown and the cancel button can barely be seen.
- Lei
On 6/7/07, Alexandre Julliard julliard@wine.codeweavers.com wrote:
Module: wine Branch: master Commit: 13f18ee7593364a2a685fed2bdfa814431906f0c URL: http://source.winehq.org/git/wine.git/?a=commit;h=13f18ee7593364a2a685fed2bd...
Author: Juan Lang juan_lang@yahoo.com Date: Thu Jun 7 12:27:11 2007 -0700
comdlg32: Initialize file dialog controls before creating dialog.
dlls/comdlg32/filedlg.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/dlls/comdlg32/filedlg.c b/dlls/comdlg32/filedlg.c index f63e64f..5409b91 100644 --- a/dlls/comdlg32/filedlg.c +++ b/dlls/comdlg32/filedlg.c @@ -1037,11 +1037,11 @@ INT_PTR CALLBACK FileOpenDlgProc95(HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM l so it will be easily accessible through a GetPropA(...) */ SetPropA(hwnd, FileOpenDlgInfosStr, (HANDLE) fodInfos);
FILEDLG95_InitControls(hwnd);
fodInfos->DlgInfos.hwndCustomDlg = CreateTemplateDialog((FileOpenDlgInfos *)lParam, hwnd);
FILEDLG95_InitControls(hwnd);
if (fodInfos->DlgInfos.hwndCustomDlg) { RECT rc;
With this patch, the bottom of file dialogs are cut off such that the file type dropdown and the cancel button can barely be seen.
In which apps? I just looked at notepad and it looks fine to me.
Also, this does correct a crash, so I'm pretty sure it's (mostly) correct. --Juan
____________________________________________________________________________________ Take the Internet to Go: Yahoo!Go puts the Internet in your pocket: mail, news, photos & more. http://mobile.yahoo.com/go?refer=1GNXIC
On 6/13/07, Juan Lang juan_lang@yahoo.com wrote:
With this patch, the bottom of file dialogs are cut off such that the file type dropdown and the cancel button can barely be seen.
In which apps? I just looked at notepad and it looks fine to me.
Also, this does correct a crash, so I'm pretty sure it's (mostly) correct. --Juan
Password Safe, http://passwordsafe.sourceforge.net/ is one such program.
It looks like a section of FILEDLG95_InitControls() checks fodInfos->DlgInfos.hwndCustomDlg. When you switched the two statements, fodInfos->DlgInfos.hwndCustomDlg always came up NULL in FILEDLG95_InitControls().
I'll send in a patch.