Hi Christian,
As tested on Windows(R) 7 Home Premium x64, "CertRDNValueToStr" Doesn't handle the quoting. Instead it's made on "CertNameToStr" with CERT_X500_NAME_STR flag.
Adding tests that demonstrate that would help a great deal.
A minor comment regarding the patch itself:
+/* Only use this function internally. */ +static DWORD QuoteCertRDNValueToStrA(DWORD dwValueType, PCERT_RDN_VALUE_BLOB pValue,
Don't use Hungarian notation for internal functions, it's hard to distinguish them from Win32 API functions. --Juan
Am 2011-01-11 00:02, schrieb Juan Lang:
Hi Christian,
hi,
Adding tests that demonstrate that would help a great deal.
I've sended my patches, they look a little bit weird, but they work.
Don't use Hungarian notation for internal functions, it's hard to distinguish them from Win32 API functions.
I've changed the function names in 'quote_string_a' and 'quote_string_w', if you meant that. If not, please say me what you've meant, because I don't know what 'Hungarian notation' is.
--Christian
-
Christian Inci -
Juan Lang