[PATCH] kernel32/tests: Open and close the right file handle (Coverity).

[Sven Baars]

Signed-off-by: Sven Baars 
---
 dlls/kernel32/tests/file.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/kernel32/tests/file.c b/dlls/kernel32/tests/file.c
index 9bf80f6388..b22ae19f2e 100644
--- a/dlls/kernel32/tests/file.c
+++ b/dlls/kernel32/tests/file.c
@@ -3735,13 +3735,13 @@ static void test_ReplaceFileA(void)
     /* replace file while replacement is opened */
     ret = GetTempFileNameA(temp_path, prefix, 0, replacement);
     ok(ret != 0, "GetTempFileNameA error (replacement) %d\n", GetLastError());
-    CreateFileA(replacement, GENERIC_READ | SYNCHRONIZE, FILE_SHARE_READ | FILE_SHARE_DELETE, NULL, OPEN_EXISTING, 0, 0);
+    hReplacementFile = CreateFileA(replacement, GENERIC_READ | SYNCHRONIZE, FILE_SHARE_READ | FILE_SHARE_DELETE, NULL, OPEN_EXISTING, 0, 0);
     ok(hReplacementFile != INVALID_HANDLE_VALUE, "unexpected error, replacement file should be able to be opened %d\n",
        GetLastError());
     ret = pReplaceFileA(replaced, replacement, NULL, 0, 0, 0);
     ok(!ret, "expect failure\n");
     ok(GetLastError() == ERROR_SHARING_VIOLATION, "expect ERROR_SHARING_VIOLATION, got %#x.\n", GetLastError());
-    CloseHandle(hReplacedFile);
+    CloseHandle(hReplacementFile);

/* replacement file still exists, make pass w/o "replaced" */
     ret = DeleteFileA(replaced);

[Zhiyi Zhang]

Signed-off-by: Zhiyi Zhang

On 5/26/19 10:07 PM, Sven Baars wrote:
> Signed-off-by: Sven Baars
>
> dlls/kernel32/tests/file.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/kernel32/tests/file.c b/dlls/kernel32/tests/file.c
> index 9bf80f6388..b22ae19f2e 100644
> --- a/dlls/kernel32/tests/file.c
> +++ b/dlls/kernel32/tests/file.c
> @@ -3735,13 +3735,13 @@ static void test_ReplaceFileA(void)
>      /* replace file while replacement is opened */
>      ret = GetTempFileNameA(temp_path, prefix, 0, replacement);
>      ok(ret != 0, "GetTempFileNameA error (replacement) %d\n", GetLastError());
> - CreateFileA(replacement, GENERIC_READ | SYNCHRONIZE, FILE_SHARE_READ | FILE_SHARE_DELETE, NULL, OPEN_EXISTING, 0, 0);
> - hReplacementFile = CreateFileA(replacement, GENERIC_READ | SYNCHRONIZE, FILE_SHARE_READ | FILE_SHARE_DELETE, NULL, OPEN_EXISTING, 0, 0);
> ok(hReplacementFile != INVALID_HANDLE_VALUE, "unexpected error, replacement file should be able to be opened %d\n",
>    GetLastError());
> ret = pReplaceFileA(replaced, replacement, NULL, 0, 0, 0);
> ok(!ret, "expect failure\n");
> ok(GetLastError() == ERROR_SHARING_VIOLATION, "expect ERROR_SHARING_VIOLATION, got %#x.\n", GetLastError());
> - CloseHandle(hReplacedFile);
> -
>
> CloseHandle(hReplacementFile);
>
> /* replacement file still exists, make pass w/o "replaced" */
> ret = DeleteFileA(replaced);