[PATCH v2 resend] comctl32: Correctly draw disabled toolbar button which contains 32 bpp bitmap with alpha channel.

[Ziqing Hui]

It has been a week since I send this patch and got no reply... so I resend it now.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=24784
Signed-off-by: Ziqing Hui 
---
 dlls/comctl32/imagelist.c |  5 +++++
 dlls/comctl32/toolbar.c   | 12 ++++++++++++
 include/commctrl.h        |  2 ++
 3 files changed, 19 insertions(+)

[Zhiyi Zhang]

> +BOOL inline imagelist_has_alpha( HIMAGELIST himl, UINT index )
> +{
> - return himl->has_alpha && himl->has_alpha[index];
>
> +}

This should be a static function. If you really need it for other files later,
you should add it to the comctl32 private header instead of the public header
commctrl.h. You can also remove inline as compilers should automatically decide
it for you.

Thanks,
Zhiyi

[Nikolay Sivov]

I would change two remaining DrawEx calls to use DrawIndirect as well, 
using same parameter structure, tweaked to do what we need each time 
obviously.

[Ziqing Hui]

Zhiyi, Nikolay, thanks for reply!

I'll make changes following your suggestions and submit a v3 version later.