Signed-off-by: Francois Gouget fgouget@codeweavers.com --- v2: Duplicate the check in ok() and if (). An alternative would be to put an else ok(0, ...) instead. --- dlls/oleaut32/tests/vartest.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/dlls/oleaut32/tests/vartest.c b/dlls/oleaut32/tests/vartest.c index b18e6e3f3a0..136d2ddd521 100644 --- a/dlls/oleaut32/tests/vartest.c +++ b/dlls/oleaut32/tests/vartest.c @@ -1288,6 +1288,7 @@ static HRESULT convert_str( const char *str, INT dig, ULONG flags, static void expect_NumFromStr( int line, HRESULT hres, NUMPARSE *np, INT a, ULONG b, ULONG c, INT d, INT e, INT f ) { + ok_(__FILE__,line)(hres == (HRESULT)S_OK, "returned %08x\n", hres); if (hres == (HRESULT)S_OK) { ok_(__FILE__,line)(np->cDig == a, "Expected cDig = %d, got %d\n", a, np->cDig);
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=94287
Your paranoid android.
=== w2008s64 (32 bit report) ===
oleaut32: vartest.c:2168: Test failed: returned 80020005
=== w7u_2qxl (32 bit report) ===
oleaut32: vartest.c:2168: Test failed: returned 80020005
=== w7u_adm (32 bit report) ===
oleaut32: vartest.c:2168: Test failed: returned 80020005
=== w7u_el (32 bit report) ===
oleaut32: vartest.c:2168: Test failed: returned 80020005
=== w8 (32 bit report) ===
oleaut32: vartest.c:2168: Test failed: returned 80020005 vartest.c:2174: Test failed: returned 80020005
=== w8adm (32 bit report) ===
oleaut32: vartest.c:2168: Test failed: returned 80020005 vartest.c:2174: Test failed: returned 80020005
=== w864 (32 bit report) ===
oleaut32: vartest.c:2168: Test failed: returned 80020005 vartest.c:2174: Test failed: returned 80020005
=== wvistau64 (64 bit report) ===
oleaut32: vartest.c:2168: Test failed: returned 80020005
=== w2008s64 (64 bit report) ===
oleaut32: vartest.c:2168: Test failed: returned 80020005
=== w864 (64 bit report) ===
oleaut32: vartest.c:2168: Test failed: returned 80020005 vartest.c:2174: Test failed: returned 80020005