Re: msvcrt: Fix strtok_s for an empty string.

[Piotr Caban]

Hi Bernhard,

On 08/18/16 03:48, Bernhard Übelacker wrote:
> - old_handler = p_set_invalid_parameter_handler(test_strtok_s_handler);

I'm not sure if it makes sense to set invalid parameter handler taking 
in account it's never called. If you don't set it and it's called the 
tests will crash.
> - context = (char*)0xdeadbeef;
> - strret = p__mbstok_s( test, "/", &context);

This will cause compilation warnings (signedness mismatch).

Thanks,
Piotr

msvcrt: Fix strtok_s for an empty string.

[Bernhard Übelacker]

Hello Piotr,
thanks for your review.

Am 18.08.2016 um 09:10 schrieb Piotr Caban:
> Hi Bernhard,
>
> On 08/18/16 03:48, Bernhard Übelacker wrote:
> > - old_handler =
> >
> > p_set_invalid_parameter_handler(test_strtok_s_handler);
>
> I'm not sure if it makes sense to set invalid parameter handler taking
> in account it's never called. If you don't set it and it's called the
> tests will crash.

The msvcr90 test sets one already in init(). But that one would
fail on an unexpected call. So I remove setting it completely.
> > - context = (char*)0xdeadbeef;
> > - strret = p__mbstok_s( test, "/", &context);
>
> This will cause compilation warnings (signedness mismatch).

Did miss these, thanks. Probably I should configure next
time with -Werror ...

I will prepare an updated patch.

Kind regards,
Bernhard