On 06/27/15 19:50, YongHaoHu wrote:
Shouldn't err_code be set to GetLastError in default case? You end up setting it to ERROR_SUCCESS in every case except if path is NULL.
Why are you handling ERROR_BAD_DEV_TYPE error here?
This will produce a compilation warning.
Cheers, Piotr
On 15/6/29 下午5:55, Piotr Caban wrote:
Yeah, you are right.
Why are you handling ERROR_BAD_DEV_TYPE error here?
I don't have special reason, just base on the test result on testbot.
Got it.
Thank you for your comment. :)
On 06/29/15 16:42, YongHaoHu wrote:
Why are you handling ERROR_BAD_DEV_TYPE error here?
I don't have special reason, just base on the test result on testbot.
It looks wrong. Could you please send the test here and point on what testbot machine it happens?
Thanks, Piotr
On 15/6/29 下午10:54, Piotr Caban wrote:
Yes, it's wrong. According to your advice, I tested GetFileAttributesA and found that its last error handling was also not correct. (It means that many ntdll functions have problems with last_error handling.) The code I used is : GetFileAttributesA("\\.\PiPe\tests_pipe.c"); printf("getlast err is %d\n", GetLastError()); The output in wine is "getlast err is 66" while "|getlast err is 0" in testbot.
Here is the test result: https://testbot.winehq.org/JobDetails.pl?Key=14832&log_101=1#k101 Plesase ignore the failed msg. |
On 06/29/15 18:46, YongHaoHu wrote:
In this case test should be marked with todo_wine and fail in wine. Other option is to fix GetFileAttributes function.