Re: hhctrl: Add the CHM implemenation

[Dmitry Timoshkov]

"James Hawkins"  wrote:
> --- /dev/null 2005-07-23 07:02:07.637731864 -0500
> +++ dlls/hhctrl.ocx/itss.h 2005-07-25 01:09:16.000000000 -0500
> @@ -0,0 +1,302 @@
> +/*** Autogenerated by WIDL 0.1 from itss.idl - Do not edit ***/

Probably we need to move itss.idl to include/ so that a generated
itss.h could be accessed globally.
> - hr = pStorage->lpVtbl->OpenStream(pStorage, stringsW, NULL, STGM_READ, 0, &pStream);

Please use IStorage_OpenStream macro here and similar macros instead
of accessing vtable directly.

hhctrl: Add the CHM implemenation

[James Hawkins]

On 7/25/05, Dmitry Timoshkov  wrote:
> Probably we need to move itss.idl to include/ so that a generated
> itss.h could be accessed globally.

When I send in a patch to move itss.idl to include/ (or whoever does
it), do I need to also include the removal of itss.idl from the itss
directory as in:

diff -u -p dlls/itss/itss.idl /dev/null

or should I just say itss.idl needs to be removed?
> > - hr = pStorage->lpVtbl->OpenStream(pStorage, stringsW, NULL, STGM_READ, 0, &pStream);
>
> Please use IStorage_OpenStream macro here and similar macros instead
> of accessing vtable directly.

I'll make these changes and send them in the next patch.  Thanks for the tips.

hhctrl: Add the CHM implemenation

[James Hawkins]

On 7/25/05, James Hawkins  wrote:
> When I send in a patch to move itss.idl to include/ (or whoever does
> it), do I need to also include the removal of itss.idl from the itss
> directory as in:
>
> diff -u -p dlls/itss/itss.idl /dev/null
>
> or should I just say itss.idl needs to be removed?

Scratch this question.  I read the winehq devel docs and found out I
just have to list the file in the email.