On December 29, 2002 07:45 pm, Dan Kegel wrote:
I added a few definitions that let this file optionally compile standalone, which made things easier on Windows.
+#include "wtypes.h" +#include "winbase.h" +#include "windef.h" +#include "shellapi.h" +#include "wine/test.h"
Please use <> instead of "" even in Wine. The old code uses "" for historical reasons that are no longer an issue. It needs to be changed (and we're waiting for some Perl wizard to help out <g>), but the new code should not perpetuate this deprecated practice IMO.
Dimitrie O. Paun wrote:
On December 29, 2002 07:45 pm, Dan Kegel wrote:
+#include "wine/test.h"
Please use <> instead of "" even in Wine. The old code uses "" for historical reasons that are no longer an issue. It needs to be changed (and we're waiting for some Perl wizard to help out <g>), but the new code should not perpetuate this deprecated practice IMO.
Yay!
OK, maybe that's another janitorial project I can take on. Is it only the test programs and winelib programs that should be converted from "" to <>, or is there more? - Dan
On December 30, 2002 12:43 pm, Dan Kegel wrote:
OK, maybe that's another janitorial project I can take on. Is it only the test programs and winelib programs that should be converted from "" to <>, or is there more?
Everything. That is, all files that include things from include/* should use <> instead of "".
On December 30, 2002 12:43 pm, Dan Kegel wrote:
OK, maybe that's another janitorial project I can take on.
You asked for it! :) http://www.dssd.ca/wine/Wine-Janitorial.html#include-quotes
-
Dan Kegel -
Dimitrie O. Paun